feat: Add open in editor button with configurable editor preference #730

VAIBHAVSING · 2025-10-10T10:20:52Z

Summary

This PR implements the ability to open a session's working directory in an external editor directly from CodeLayer.

Changes

Added an 'Open in Editor' button (📝 icon) next to the Archive button in the session detail view
Added a settings section to configure the preferred editor (Cursor, VS Code, or Zed)
Implemented Cmd+Shift+E (⌘+Shift+E on Mac, Ctrl+Shift+E on Windows/Linux) hotkey to open the working directory
Used tauri-plugin-opener for cross-platform editor launching

Implementation Details

Added new preferences in src/lib/preferences.ts for storing editor choice
Updated ActionButtons component to include the new button
Updated ResponseInput component to handle the editor opening logic and hotkey
Added editor selection dropdown in SettingsDialog

Testing

Ran existing tests - all previously passing tests still pass
Ran linter - no new warnings introduced
TypeScript compilation successful for our changes

Closes #479

Important

Adds 'Open in Editor' feature with configurable editor preference and hotkey support in CodeLayer.

Behavior:
- Adds 'Open in Editor' button in ActionButtons and ActiveSessionActionButtons components.
- Supports editors: Cursor, VS Code, Zed, and system default.
- Implements hotkey Cmd+Shift+E for opening the editor.
Preferences:
- Adds PREFERRED_EDITOR_KEY in preferences.ts for storing preferred editor.
- Provides editor options in EDITOR_OPTIONS.
- Updates SettingsDialog to include editor selection dropdown.
Commands:
- Adds open_in_editor command in lib.rs to handle directory opening logic.
- Uses tauri-plugin-opener for cross-platform support.
Testing:
- Existing tests pass, no new warnings from linter.
- TypeScript compilation successful.

^{This description was created by}^{for e908159. You can customize this summary. It will automatically update as commits are pushed.}

ellipsis-dev

Important

Looks good to me! 👍

Reviewed everything up to 2d60767 in 1 minute and 10 seconds. Click for details.

Reviewed 277 lines of code in 4 files
Skipped 0 files when reviewing.
Skipped posting 5 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. humanlayer-wui/src/components/SettingsDialog.tsx:47

Draft comment:
Ensure 'fetchClaudeConfig' is stable in the useEffect dependencies to avoid unnecessary re-fetches.
Reason this comment was not posted:
Confidence changes required: 33% <= threshold 50% None

2. humanlayer-wui/src/components/SettingsDialog.tsx:172

Draft comment:
Consider validating the selected editor value against EDITOR_OPTIONS in handleEditorChange to guard against unexpected values.
Reason this comment was not posted:
Confidence changes required: 33% <= threshold 50% None

3. humanlayer-wui/src/components/internal/SessionDetail/components/ActionButtons.tsx:127

Draft comment:
Consider using a more distinct icon than Pencil for the 'Open in Editor' action to avoid confusion with text editing.
Reason this comment was not posted:
Confidence changes required: 20% <= threshold 50% None

4. humanlayer-wui/src/components/internal/SessionDetail/components/ResponseInput.tsx:396

Draft comment:
Specify a dependency array for the 'mod+shift+e' hotkey callback to ensure updated session values (e.g. workingDir, isDraft) are correctly captured.
Reason this comment was not posted:
Confidence changes required: 33% <= threshold 50% None

5. humanlayer-wui/src/lib/preferences.ts:31

Draft comment:
Consider validating the stored editor preference to ensure it matches one of the allowed values ('cursor', 'code', 'zed').
Reason this comment was not posted:
Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_8ADAP84yyfZAVwwD

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

ellipsis-dev

Important

Looks good to me! 👍

Reviewed everything up to e908159 in 42 seconds. Click for details.

Reviewed 593 lines of code in 11 files
Skipped 1 files when reviewing.
Skipped posting 3 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. humanlayer-wui/src/lib/preferences.ts:40

Draft comment:
Casting the stored value to EditorType without validation may lead to unexpected behavior if the stored value is invalid. Consider parsing or validating the value before defaulting to 'cursor'.
Reason this comment was not posted:
Confidence changes required: 33% <= threshold 50% None

2. humanlayer-wui/src/components/internal/SessionDetail/components/ActiveSessionInput.tsx:272

Draft comment:
The useImperativeHandle hook is used with an empty dependency array. Although refs are stable, ensure that it's safe to assume that tiptapRef.current remains unchanged. If not, consider adding tiptapRef as a dependency.
Reason this comment was not posted:
Confidence changes required: 33% <= threshold 50% None

3. humanlayer-wui/src/components/internal/SessionDetail/components/ActiveSessionInput.tsx:293

Draft comment:
The async setup for drag-and-drop event handling may be subject to race conditions if the component unmounts during setup. Ensure that the cleanup is robust (e.g. by verifying component mounted state) to avoid potential memory leaks.
Reason this comment was not posted:
Confidence changes required: 50% <= threshold 50% None

Workflow ID: wflow_dk4LdC3RnrsmxRNk

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

VAIBHAVSING · 2025-10-19T11:51:20Z

@dexhorthy PTAL
hopefully its working on mac
now it working on ubantu

VAIBHAVSING · 2025-10-19T11:53:05Z

dexhorthy · 2025-10-19T16:43:49Z

related to #479

K-Mistele

The sub-text is hard to read here when a given option is focused - it should probably change to be more visible like how most of our buttons do

Also, the "Cursor" text in the select component's selection appears to have a weird left indent, and that box could use a bit more padding as well

left a few other comments too

K-Mistele · 2025-10-23T21:00:13Z

humanlayer-wui/src/components/internal/SessionDetail/components/ActionButtons.tsx

+          </TooltipTrigger>
+          <TooltipContent>
+            <p className="flex items-center gap-1">
+              Open in editor <KeyboardShortcut keyString="⌘+Shift+E" />


in other places we are using the shift unicode character, it's spelled out here - this should probably be changed

K-Mistele · 2025-10-23T21:00:43Z

humanlayer-wui/src/components/internal/SessionDetail/components/ActiveSessionActionButtons.tsx

  sessionStatus,
  isArchived,
+  workingDir,
+  preferredEditor = 'cursor',


imho the default should be VS Code not cursor since VS Code is far more likely to be installed

K-Mistele · 2025-10-23T21:04:13Z

humanlayer-wui/src/components/internal/SessionDetail/components/ActiveSessionInput.tsx

+    // Cmd+Shift+E to open in editor
+    useHotkeys(
+      'mod+shift+e',
+      e => {
+        e.preventDefault()
+        if (session.workingDir) {
+          handleOpenInEditor()
+        }
+      },
+      { enableOnFormTags: true },
+    )
+


This hotkey does not appear to have a scope configured properly, please review other usages of this hook in the codebase to understand how scopes work. probably this should be in sessions.details scope but tbh I'd just tell claude to dig into how hotkey scopes and hotkey boundaries work (pattern locator agent should be good for this) and make a recommendation

Also enableOnContentEditable is probably appropriate as well

VAIBHAVSING · 2025-11-03T12:38:31Z

Implementation Update for PR #730

I've addressed the feedback from the PR review with the following key improvements:

✅ Changes Implemented

Switched to tauri-plugin-opener for cross-platform compatibility
- Removed custom shell command logic (400+ lines)
- Now uses native Tauri opener API for reliable editor launching
- Works on macOS without requiring CLI tools to be installed
- Platform-specific app name mapping (e.g., "Visual Studio Code" on macOS, "Code" on Windows)
Changed default editor from Cursor to VS Code
- Updated default in preferences
- VS Code is more commonly installed across platforms
Fixed keyboard shortcut display
- Changed from ⌘+Shift+E to ⌘⇧E to match codebase style
- Now consistent with other keyboard shortcuts in the app
Added proper hotkey scope configuration
- Added HOTKEY_SCOPES.SESSION_DETAIL and SESSION_DETAIL_ARCHIVED scopes
- Added enableOnContentEditable: true for proper editor integration
- Hotkey now properly scoped to session detail views

🔄 Remaining Work

The Settings UI improvements are not yet implemented. This requires:

Making the editor selector match the model selector button style
Improving focus states for better readability
Fixing padding and indentation issues

I plan to address the UI improvements in a follow-up commit after getting feedback on the core functionality changes.

🧪 Testing Needed

Please test on macOS to verify that editors open correctly without CLI tools installed. The new implementation should work with just the applications installed in /Applications.

cc @dexhorthy @K-Mistele - ready for review!

- Add 'Open in Editor' button next to Archive button in session detail - Support Cursor, VS Code, and Zed editors - Add editor preference selector in Settings dialog - Implement Cmd+Shift+E hotkey to open working directory in preferred editor - Use tauri-plugin-opener for cross-platform editor launching Resolves humanlayer#479

dexhorthy · 2025-11-03T13:06:39Z

Thanks I'll check this out

…

On Mon, Nov 3, 2025 at 4:38 AM, Vaibhav Patil < ***@***.*** > wrote: *VAIBHAVSING* left a comment (humanlayer/humanlayer#730) ( #730 (comment) ) --------------------------------------------------------------------------------------- Implementation Update for PR #730 ( #730 ) --------------------------------------------------------------------------------------- I've addressed the feedback from the PR review with the following key improvements: ✅ Changes Implemented --------------------- * *Switched to tauri-plugin-opener for cross-platform compatibility* * Removed custom shell command logic (400+ lines) * Now uses native Tauri opener API for reliable editor launching * Works on macOS without requiring CLI tools to be installed * Platform-specific app name mapping (e.g., "Visual Studio Code" on macOS, "Code" on Windows) * *Changed default editor from Cursor to VS Code* * Updated default in preferences * VS Code is more commonly installed across platforms * *Fixed keyboard shortcut display* * Changed from ⌘+Shift+E to ⌘⇧E to match codebase style * Now consistent with other keyboard shortcuts in the app * *Added proper hotkey scope configuration* * Added HOTKEY_SCOPES.SESSION_DETAIL and SESSION_DETAIL_ARCHIVED scopes * Added enableOnContentEditable: true for proper editor integration * Hotkey now properly scoped to session detail views 📝 Commits --------- * 7f04001 - refactor: use tauri-plugin-opener for editor launch * d91d221 - feat: change default editor to VS Code * b7bf598 - fix: use unicode shift character in keyboard shortcut * 857218f - fix: add proper hotkey scope and contentEditable support 🔄 Remaining Work ---------------- The *Settings UI improvements* are not yet implemented. This requires: * Making the editor selector match the model selector button style * Improving focus states for better readability * Fixing padding and indentation issues I plan to address the UI improvements in a follow-up commit after getting feedback on the core functionality changes. 🧪 Testing Needed ---------------- Please test on macOS to verify that editors open correctly without CLI tools installed. The new implementation should work with just the applications installed in /Applications. cc @dexhorthy ( https://github.com/dexhorthy ) @K-Mistele ( https://github.com/K-Mistele ) - ready for review! — Reply to this email directly, view it on GitHub ( #730 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AA4OZLPELJ7MDVFP3UNP4CL325EF5AVCNFSM6AAAAACI2LCPVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIOBQGMZDGOBQGI ). You are receiving this because you were mentioned. Message ID: <humanlayer/humanlayer/pull/730/c3480323802 @ github. com>

- Resolved conflicts in lib.rs by keeping both read_last_log_lines and save_window_state functions - Resolved conflicts in SettingsDialog.tsx by merging editor preferences with log handling - Combined imports and state management from both branches - Applied UI improvements: better padding, improved focus states for select items

@K-Mistele

- Add px-2.5 padding to SelectTrigger to fix weird left indent - Change description text from text-muted-foreground to opacity-70 with group-data state - Make sub-text more readable when focused by increasing opacity on focus - Update keyboard shortcut display from ⌘+Shift+E to ⌘⇧E - Add group class to SelectItem for better state management Addresses feedback from @K-Mistele in PR humanlayer#730

ellipsis-dev bot reviewed Oct 10, 2025

View reviewed changes

VAIBHAVSING marked this pull request as draft October 10, 2025 10:32

VAIBHAVSING force-pushed the feat/open-in-editor-479 branch from 34d161d to 7c7b00a Compare October 18, 2025 07:54

VAIBHAVSING marked this pull request as ready for review October 19, 2025 11:50

ellipsis-dev bot reviewed Oct 19, 2025

View reviewed changes

dexhorthy mentioned this pull request Oct 19, 2025

Open Cursor Editor from Working Directory #479

Open

K-Mistele requested changes Oct 23, 2025

View reviewed changes

VAIBHAVSING added 9 commits November 3, 2025 18:21

style: Format code with prettier

69c40cb

feat : added open in IDE feature to pwd to an editor

d5ad8a7

feat :format

c9c7263

feat: refractor

d96e76b

refactor: use tauri-plugin-opener for editor launch

c290a85

feat: change default editor to VS Code

b8461a5

fix: use unicode shift character in keyboard shortcut

9a3e83d

fix: add proper hotkey scope and contentEditable support

df905c8

VAIBHAVSING force-pushed the feat/open-in-editor-479 branch from 857218f to df905c8 Compare November 3, 2025 12:51

VAIBHAVSING added 2 commits November 3, 2025 18:55

VAIBHAVSING requested a review from K-Mistele November 3, 2025 13:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add open in editor button with configurable editor preference #730

feat: Add open in editor button with configurable editor preference #730

Uh oh!

VAIBHAVSING commented Oct 10, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

VAIBHAVSING commented Oct 19, 2025

Uh oh!

VAIBHAVSING commented Oct 19, 2025

Uh oh!

dexhorthy commented Oct 19, 2025

Uh oh!

K-Mistele left a comment •

edited

Loading

Uh oh!

K-Mistele Oct 23, 2025

Uh oh!

K-Mistele Oct 23, 2025

Uh oh!

K-Mistele Oct 23, 2025

Uh oh!

VAIBHAVSING commented Nov 3, 2025 •

edited

Loading

Uh oh!

dexhorthy commented Nov 3, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: Add open in editor button with configurable editor preference #730

Are you sure you want to change the base?

feat: Add open in editor button with configurable editor preference #730

Uh oh!

Conversation

VAIBHAVSING commented Oct 10, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Implementation Details

Testing

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

VAIBHAVSING commented Oct 19, 2025

Uh oh!

VAIBHAVSING commented Oct 19, 2025

Uh oh!

dexhorthy commented Oct 19, 2025

Uh oh!

K-Mistele left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

K-Mistele Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

K-Mistele Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

K-Mistele Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

VAIBHAVSING commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implementation Update for PR #730

✅ Changes Implemented

🔄 Remaining Work

🧪 Testing Needed

Uh oh!

dexhorthy commented Nov 3, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

VAIBHAVSING commented Oct 10, 2025 •

edited by ellipsis-dev bot

Loading

K-Mistele left a comment •

edited

Loading

VAIBHAVSING commented Nov 3, 2025 •

edited

Loading