chore: remove cron for linear layer (leave workflow disaptch enabled) #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 605a4ef in 45 seconds. Click for details.
- Reviewed
54lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/linear-create-plan.yml:2
- Draft comment:
Removed push and schedule triggers; confirm that manual workflow_dispatch is now the sole trigger. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. .github/workflows/linear-implement-plan.yml:2
- Draft comment:
Removed automated push and cron schedule triggers; ensure manual triggering meets your requirements. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. .github/workflows/linear-research-tickets.yml:2
- Draft comment:
Removed push and schedule triggers and cleaned up minor whitespace; verify that manual dispatch is sufficient. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_hS5tKGcuuWRbOo5u
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Contributor
|
approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
What user-facing changes did I ship?
How I implemented it
How to verify it
make check testpassesDescription for the changelog
A picture of a cute animal (not mandatory but encouraged)
Important
Remove cron and push triggers from Linear workflows, retaining only manual dispatch.
cronschedule andpushtriggers fromlinear-create-plan.yml,linear-implement-plan.yml, andlinear-research-tickets.yml.workflow_dispatchtrigger in all three workflows.This description was created by
for 605a4ef. You can customize this summary. It will automatically update as commits are pushed.