Linear cli #836
Merged
Linear cli #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 7254092 in 3 minutes and 4 seconds. Click for details.
- Reviewed
456lines of code in2files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/release-macos.yml:317
- Draft comment:
The brew install command now uses the '--no-quarantine' flag and removes the tap command. Disabling quarantine can bypass macOS security checks. Please ensure this change is intentional and document the rationale behind it. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =40%<= threshold50%The comment is asking the PR author to ensure the change is intentional and to document the rationale, which violates the rules. However, it does point out a potential security issue with disabling quarantine, which could be useful. The comment could be rephrased to focus on confirming the intention without asking for documentation.
2. hack/linear/linear-cli.ts:115
- Draft comment:
The regex in extractIssueId has been updated to allow alphanumeric prefixes (e.g. B2BPROD-206). Consider extracting the regex pattern into a constant to avoid duplication in later validations. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
3. hack/linear/linear-cli.ts:1129
- Draft comment:
The help description for the get-issue-v2 command mentions the 'parents' field, but the default value does not include it. Consider aligning the default fields with the documentation if 'parents' is meant to be included. - Reason this comment was not posted:
Comment looked like it was already resolved.
4. hack/linear/linear-cli.ts:556
- Draft comment:
Images in fetchImages are downloaded sequentially in a loop. Consider using Promise.all or another concurrent approach to improve performance when dealing with many images. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. hack/linear/linear-cli.ts:1189
- Draft comment:
In the bash completion script generation, the JavaScript variable 'commands' is interpolated via '${commands.join(' ')}', but a local shell variable 'commands' is also declared. This could be confusing and may lead to unintended behavior. Consider renaming the JavaScript variable to avoid potential naming conflicts. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_osSECtEGBtGwlII1
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
| await displayIssue(issue); | ||
|
|
||
| // Fetch and display parent issues | ||
| const parentIssues = []; |
Contributor
There was a problem hiding this comment.
The logic for fetching and displaying parent issues is duplicated in both getIssue and getIssueV2. Consider refactoring this into a shared helper function to improve maintainability.
K-Mistele
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
What user-facing changes did I ship?
How I implemented it
How to verify it
make check testpassesDescription for the changelog
A picture of a cute animal (not mandatory but encouraged)
Important
Adds
assign-to-mecommand, enhances issue ID pattern matching, and updates Homebrew installation command.assign-to-mecommand inlinear-cli.tsto assign issues to the current user.extractIssueId()andresolveIssueId().release-macos.ymlto include--no-quarantineflag.assignToMe()function inlinear-cli.tsto handle issue assignment.getIssue()andgetIssueV2()to display parent issues.updateStatus(),addLink(), andfetchImages()to support alphanumeric prefixes.This description was created by
for 7254092. You can customize this summary. It will automatically update as commits are pushed.