chore: disable nightly #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to fa06ddc in 1 minute and 39 seconds. Click for details.
- Reviewed
31lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/release-macos.yml:4
- Draft comment:
Disabled schedule trigger: Confirm that commenting out the schedule is the intended way to disable nightly releases. If nightly builds are no longer needed, consider removing related conditional logic in the release script for clarity. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This comment clearly violates multiple rules. First, it starts with "Confirm that..." which is explicitly called out in the rules as a pattern that indicates the comment is likely not useful. The rules state: "Do NOT ask the PR author to confirm their intention, to explain, to double-check things, to ensure the behavior is intended." Second, the suggestion to "consider removing related conditional logic" is speculative - the author may have intentionally kept the nightly build logic for manual workflow_dispatch triggers. The change only comments out the automatic schedule, but nightly builds can still be triggered manually. There's no strong evidence that the conditional logic should be removed. Could the author have accidentally left the schedule commented out when they meant to remove it entirely? Perhaps there's a broader refactoring plan where nightly builds are being phased out completely, and this comment is trying to be helpful by pointing out leftover logic. Even if there's a broader plan to phase out nightly builds, the comment is still asking for confirmation rather than pointing out a definite issue. The workflow still supports manual nightly builds via workflow_dispatch, so the conditional logic is still functional and needed. The comment doesn't provide strong evidence that anything is wrong - it's purely asking the author to confirm and consider changes. This comment should be deleted. It explicitly asks the author to "confirm" their intention, which violates the rules. It also makes a speculative suggestion to "consider removing" logic without strong evidence that it's incorrect or problematic. The nightly build logic is still used for manual workflow_dispatch triggers.
2. .github/workflows/release-macos.yml:18
- Draft comment:
Changing default release_version from '' to "" is fine; ensure consistency across workflows. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_twplzdVmvLpkT2pt
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
balanceiskey
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
What user-facing changes did I ship?
How I implemented it
How to verify it
make check testpassesDescription for the changelog
A picture of a cute animal (not mandatory but encouraged)
Important
Disables nightly build schedule in
release-macos.ymlby commenting out the cron schedule.release-macos.ymlby commenting out the cron schedule.release-macos.yml.This description was created by
for fa06ddc. You can customize this summary. It will automatically update as commits are pushed.