这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@balanceiskey
Copy link
Contributor

@balanceiskey balanceiskey commented Oct 28, 2025

What problem(s) was I solving?

The fuzzy search dropdown used for selecting directories in the draft session launcher was rendering with an extremely narrow width, making it difficult to read and select directory paths. This affected both the working directory input field and the additional directories dropdown.

The issue was introduced in PR #798 (commit c24f2956) when implementing directory validation and creation features. During development, the CSS class controlling the popover width (w-[var(--radix-popover-trigger-width)]) was commented out, likely for debugging purposes, but was never restored.

What user-facing changes did I ship?

Fixed: The fuzzy search dropdown now correctly matches the width of its trigger input field, making directory paths fully readable when browsing and selecting directories in the draft session launcher.

Affected Components:

  • Working directory input field in draft launcher
  • Additional directories dropdown in draft launcher
  • Any other component using FuzzySearchInput / SearchInput

How I implemented it

Uncommented the CSS class w-[var(--radix-popover-trigger-width)] in FuzzySearchInput.tsx at line 287.

This Radix UI CSS variable contains the width of the popover's trigger element (the input field), and applying it ensures the dropdown matches the input width instead of defaulting to content-based width.

Technical Details:

  • File: humanlayer-wui/src/components/FuzzySearchInput.tsx
  • Change: Restored commented-out width class on PopoverContent component
  • The --radix-popover-trigger-width CSS variable is automatically provided by Radix UI's Popover component

How to verify it

Automated Checks

  • TypeScript compilation passes (bun run typecheck)
  • Linting passes (bun run lint)

Manual Testing

To verify the fix works:

  1. Launch the WUI application
  2. Navigate to Sessions page
  3. Click "Create" to start a new draft session
  4. In the "WORKING DIRECTORY" field, start typing a path (e.g., /)
  5. Expected: The dropdown should match the width of the input field
  6. Before fix: Dropdown was very narrow (content-width only)
  7. Click "Additional Directories" and test the fuzzy search there
  8. Expected: Same full-width behavior

Regression testing:

  • Verify fuzzy search still filters directories correctly
  • Verify keyboard navigation (up/down arrows) still works
  • Verify recent directories still appear
  • Verify invalid path warnings still display

Description for the changelog

Fix fuzzy search dropdown width in draft session launcher - dropdown now correctly matches input field width instead of being too narrow to read directory paths

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 199a704 in 1 minute and 3 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. humanlayer-wui/src/components/FuzzySearchInput.tsx:286
  • Draft comment:
    Uncommenting the width styling (w-[var(--radix-popover-trigger-width)]) restores the intended behavior. Ensure that the CSS variable '--radix-popover-trigger-width' is defined so that the popover width adjusts correctly.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_l5yzuH4LZFsxTYHK

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@K-Mistele K-Mistele merged commit 37ab9a0 into humanlayer:main Oct 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants