just fix the placeholder stable release notes #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to e6fbaf9 in 52 seconds. Click for details.
- Reviewed
29lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/release-macos.yml:317
- Draft comment:
Updated Homebrew command: Removed redundant 'brew tap' and added the '--no-quarantine' flag to bypass Gatekeeper. Confirm that using the fully qualified cask is intended. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. .github/workflows/release-macos.yml:321
- Draft comment:
Removed manual installation and troubleshooting instructions in favor of Homebrew installation. Verify that DMG installs are indeed no longer supported. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify if DMG installs are no longer supported, which is against the rules as it asks for confirmation of intention. It does not provide a specific code suggestion or ask for a test to be written.
Workflow ID: wflow_OTqFd3LXgAASrUb4
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are placeholder notes that get created before the actual notes go in. But they should still be accurate
Important
Updated
release-macos.ymlto refine Homebrew installation instructions and remove unsupported DMG installation steps.release-macos.yml, updated Homebrew installation command to include--no-quarantineflag.--no-quarantinedue to lack of app signing support in private beta.This description was created by
for e6fbaf9. You can customize this summary. It will automatically update as commits are pushed.