Fix Resource Leak in MCPServerManager's disconnectServerLocked Method #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erverLocked method by properly terminating stdio processes. Currently, the method only calls conn.Client.Close() but doesn't explicitly terminate the process referenced by conn.Command for stdio servers. This could lead to orphaned processes if the client's Close method doesn't handle process termination properly. The fix should add explicit process termination for stdio servers before removing the connection from the map.
|
|
Contributor
|
seems reasonable as well |
Contributor
|
Need a test to ensure this actually works. Started looking a little locally and threw some tests at this and it didn't fly by easily. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
A potential resource leak was discovered in the
disconnectServerLockedmethod of the MCP Manager subsystem. For stdio servers, the method was not explicitly terminating the associated processes, which could lead to orphaned processes.Changes
Process.Kill()to ensure the process is terminatedImpact
Files Modified
acp/internal/mcpmanager/mcpmanager.goVerification