ENG-1236 Handle Missing Dependencies by Keeping Agents in Pending State #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add StatusPending constant to track resource initialization state - Modify validation methods to return boolean for missing dependency scenarios - Update Reconcile method to handle missing dependencies for LLM, MCP servers, and contact channels - Add setStatusPending function to manage resources with unmet dependencies - Update tests to verify pending state and requeue behavior for non-existent resources
|
|
Contributor
|
seems a little bloated for not much value add? |
Contributor
|
I don't like the bool handling stuff. Closing for now as bismith cannot take feedback and make changes. Potential to apply feedback on initial linear ticket or re-run and see if it gets it better the second time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Implement status pending handling for missing dependencies