Allison/eng 1215 acp mcp tool naming bug #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0b0a041 in 1 minute and 10 seconds
More details
- Looked at
50lines of code in3files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. acp/config/manager/kustomization.yaml:6
- Draft comment:
Verify if setting newName to 'controller' (removing registry) is intentional. This changes image source from ghcr.io/humanlayer/agentcontrolplane. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
The comment is asking for verification of intention, which explicitly violates our rules. It starts with "Verify if..." which is a red flag. The change is clearly deliberate as it's changing both the registry and the tag format. We should trust the author knows what they're doing with image references.
The change in registry could potentially cause deployment issues if the new registry isn't accessible. This might be a legitimate concern.
While registry accessibility is important, asking for verification of intention doesn't help - the author needs to test their changes anyway, and we're told to trust dependency-related changes.
Delete the comment as it violates our rules by asking for verification of intention and dealing with dependency/registry changes which we're told to ignore.
2. acp/config/samples/acp_v1alpha1_claude_task.yaml:8
- Draft comment:
Property renamed from 'message' to 'userMessage'. Ensure all references match the updated Task spec. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is asking the author to ensure that all references match the updated Task spec. This is a form of asking the author to double-check their work, which violates the rules. The comment does not provide a specific suggestion or point out a specific issue, so it should be removed.
3. acp/internal/controller/task/task_controller.go:360
- Draft comment:
Refactored collectTools iterates over agent.Spec.MCPServers which improves server-tool association; confirm that serverRef.Name is used correctly and GetTools returns expected results. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =20%<= threshold50%
The comment is asking the PR author to confirm the correct usage ofserverRef.Nameand the expected results ofGetTools. This violates the rule against asking the author to confirm their intention or to ensure behavior is intended. However, it does mention an improvement in server-tool association, which could be useful information, but the main focus is on confirmation, which is not allowed.
4. acp/config/manager/kustomization.yaml:7
- Draft comment:
Changed image newName from 'ghcr.io/humanlayer/agentcontrolplane' to 'controller'. Verify this is intentional and that the image reference is correct. Also, newTag '202504151521' deviates from semantic versioning; confirm it is expected. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =50%<= threshold50%
The comment is asking the PR author to verify their intention, which violates the rules. However, it also points out a potential issue with the image reference and the tag deviating from semantic versioning, which could be useful. I need to determine if the useful parts outweigh the rule violation.
5. acp/config/samples/acp_v1alpha1_claude_task.yaml:8
- Draft comment:
Renamed field from 'message' to 'userMessage'. Ensure all related code and CRD validations are updated accordingly. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is asking the author to ensure that all related code and CRD validations are updated. This falls under asking the author to double-check things, which is against the rules. Therefore, this comment should be removed.
6. acp/internal/controller/task/task_controller.go:361
- Draft comment:
Refactored MCP tools collection: iterating over each MCP server using serverRef.Name. Confirm that using serverRef.Name for tool conversion and association is correct, and that cases with missing or duplicate servers are handled appropriately. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =40%<= threshold50%
The comment is asking the PR author to confirm their intention regarding the use ofserverRef.Nameand handling of missing or duplicate servers. This violates the rule against asking the author to confirm their intention or ensure behavior is intended. However, it does point out a potential issue with handling missing or duplicate servers, which could be useful.
Workflow ID: wflow_XiS3JllDxh9EzY03
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
balanceiskey
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes tool naming bug by updating tool collection logic in
task_controller.goand renaming configuration fields.collectTools()intask_controller.goto iterate through each MCP server directly, maintaining server-tool association.task_controller.go.newNameandnewTaginkustomization.yamltocontrollerand"202504151521"respectively.messagetouserMessageinacp_v1alpha1_claude_task.yaml.This description was created by
for 0b0a041. It will automatically update as commits are pushed.