Implement Human ContactChannel integration for using humans as tools during Task runs #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexhorthy
reviewed
Apr 8, 2025
| // Update with call ID and requeue | ||
| callId := functionCall.GetCallId() | ||
| trtc.Status.ExternalCallID = callId | ||
| if err := r.Status().Update(ctx, trtc); err != nil { |
Contributor
There was a problem hiding this comment.
this is not following the pattern of doing a deepcopy for status changes. Maybe that's ok, esp if you have bigger plans for this controller/refac
dexhorthy
approved these changes
Apr 8, 2025
Contributor
dexhorthy
left a comment
There was a problem hiding this comment.
couple small things overall looks good
balanceiskey
commented
Apr 11, 2025
|
|
||
| // TaskRunToolCallPhase represents the phase of a TaskRunToolCall | ||
| // +kubebuilder:validation:Enum=Pending;Running;Succeeded;Failed;AwaitingHumanInput;AwaitingSubAgent;AwaitingHumanApproval;ReadyToExecuteApprovedTool;ErrorRequestingHumanApproval;ToolCallRejected | ||
| // +kubebuilder:validation:Enum=Pending;Running;Succeeded;Failed;AwaitingHumanInput;AwaitingSubAgent;AwaitingHumanApproval;ReadyToExecuteApprovedTool;ErrorRequestingHumanApproval;ToolCallRejected;ErrorRequestingHumanInput |
Contributor
Author
There was a problem hiding this comment.
Note for myself, think we should just consolidate ErrorRequestingHuman* into ErrorExternalCallRequest or the like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite happy just yet with where we're at on this, here are some things that we need to address
Taskreconciler that looks like 400s to our LLM provider:2025-04-08T11:47:49-05:00 DEBUG events langchain API call failed: API returned unexpected status code: 400: An assistant message with 'tool_calls' must be followed by tool messages responding to each 'tool_call_id'. The following tool_call_ids did not have response messages: call_L4XbOAVTfMYK4u9UXrrgcStS {"type": "Warning", "object": {"kind":"Task","namespace":"default","name":"fetch-task","uid":"25e92668-e7d3-4ca7-9d1d-e3b24faae55b","apiVersion":"kubechain.humanlayer.dev/v1alpha1","resourceVersion":"681182"}, "reason": "LLMRequestFailed"}.