[ENG-1171] Add ToolType to TRTC #57
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ToolType enum to identify tools more reliably - Add KubechainToolType field to llmclient.Tool for internal tracking - Update tool creation functions to set appropriate tool types - Modify isMCPTool to use ToolType field - Pass tools through function chain for better data flow - Update createToolCalls to set ToolType in TaskRunToolCall 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Merged
Contributor
Author
|
Closing in favor of #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we doing this - Today when we create TRTCs, they can be sourced from other normal tools or "MCP" tools and we differentiate between these largely based on the name of the tool. However, as well look to add tools that will require human input and subsequently affect the TRTC flow/statuses/etc. we need some way to differentiate. This PR adds
ToolTypeto the TRTC to allow for that differentiation.