[ENG-1127] Transition TaskRunToolCall to AwaitingHumanApproval when contact channel defined
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexhorthy
approved these changes
Mar 24, 2025
dexhorthy
reviewed
Mar 24, 2025
|
|
||
| if needsApproval { | ||
| trtc.Status.Status = "AwaitingHumanApproval" | ||
| trtc.Status.StatusDetail = fmt.Sprintf("Waiting for human approval via contact channel %s", mcpServer.Spec.ApprovalContactChannel.Name) |
Contributor
There was a problem hiding this comment.
- fetch the contact channel based on the MCP server ref
- create a post /humanlayer/v1/function_calls
- store the call ID on the status
- requeue in 5 seconds
- in reconcile loop
if status == AwaitingHumanApproval {
GET /humanalyer/v1/function_calls/{call_id}
if not finished:
requeue in 5s
else -> either execute tool, or set output to denied
Contributor
Author
|
A note here, going to add a bit more on top of this PR to push it further toward making the actual call to HL per @dexhorthy's note above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.