Allison/eng 1112 support for mcp tools #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexhorthy
reviewed
Mar 22, 2025
dexhorthy
reviewed
Mar 22, 2025
dexhorthy
reviewed
Mar 22, 2025
dexhorthy
reviewed
Mar 22, 2025
dexhorthy
approved these changes
Mar 22, 2025
Contributor
|
lgtm so far. very cool |
dexhorthy
reviewed
Mar 22, 2025
|
|
||
| // ValueFrom represents a source for the value of an environment variable | ||
| // +optional | ||
| ValueFrom *EnvVarSource `json:"valueFrom,omitempty"` |
Contributor
There was a problem hiding this comment.
probably overkill for now, but did you consider importing from upstream? https://github.com/kubernetes/kubernetes/blob/9a8c2a9fa362db2ba59aa56481772060073c99d5/pkg/apis/core/types.go#L2203
on the other hand, i kinda like just copying here since it means we can articulate in the schema that we only support a subset of the "standard" pod spec methods for env stuff
dexhorthy
approved these changes
Mar 22, 2025
Contributor
dexhorthy
left a comment
There was a problem hiding this comment.
overall approved, makes sense once ci passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.