这是indexloc提供的服务，不要输入任何密码
Skip to content

using channelToken and baseURL instead of responseURL #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

using channelToken and baseURL instead of responseURL #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a81c55
initial channelToken implementation
allisoneer May 21, 2025
5248628
handle channelToken better
allisoneer May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions acp/api/v1alpha1/task_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,13 @@ type TaskSpec struct {
// +optional
ContextWindow []Message `json:"contextWindow,omitempty"`

// ResponseURL specifies a pre-generated URL that will be used for human contact responses.
// This allows the system to direct responses to a specific endpoint.
// BaseURL specifies the base URL for the human contact channel.
// +optional
ResponseURL string `json:"responseURL,omitempty"`
BaseURL string `json:"baseURL,omitempty"`

// ChannelTokenFrom references a secret containing the token for the human contact channel.
// +optional
ChannelTokenFrom *SecretKeyRef `json:"channelTokenFrom,omitempty"`
Copy link
Contributor

@dexhorthy dexhorthy May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was hoping this would be a contactChannelRef, and the baseURL/channelToken moves to ContactChannel CR

}

// Message represents a single message in the conversation
Expand Down
5 changes: 5 additions & 0 deletions acp/api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 18 additions & 5 deletions acp/config/crd/bases/acp.humanlayer.dev_tasks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,24 @@ spec:
required:
- name
type: object
baseURL:
description: BaseURL specifies the base URL for the human contact
channel.
type: string
channelTokenFrom:
description: ChannelTokenFrom references a secret containing the token
for the human contact channel.
properties:
key:
description: Key is the key in the secret
type: string
name:
description: Name is the name of the secret
type: string
required:
- key
- name
type: object
contextWindow:
description: |-
ContextWindow provides the initial conversation context when creating a Task.
Expand Down Expand Up @@ -153,11 +171,6 @@ spec:
- role
type: object
type: array
responseURL:
description: |-
ResponseURL specifies a pre-generated URL that will be used for human contact responses.
This allows the system to direct responses to a specific endpoint.
type: string
userMessage:
description: |-
UserMessage is the message to send to the agent.
Expand Down
2 changes: 1 addition & 1 deletion acp/config/localdev/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ patches:
images:
- name: controller
newName: controller
newTag: "202505141822"
newTag: "202505211432"
6 changes: 5 additions & 1 deletion acp/config/samples/acp_v1alpha1_task.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
apiVersion: acp.humanlayer.dev/v1alpha1
apiVersion: acp.humanlayer.dev/v1alpha1
kind: Task
metadata:
name: fetch-example
spec:
agentRef:
name: web-fetch-agent
userMessage: "Please fetch the content from example.com and summarize what's on the site."
baseURL: "https://api.humanlayer.dev"
channelTokenFrom:
name: channel-token-secret
key: token
146 changes: 0 additions & 146 deletions acp/internal/controller/task/send_response_url_test.go
View file
Open in desktop

This file was deleted.

Loading
Loading