Resolve #2431: Remove macos-13 from tests #2906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in huggingface#2431 since there are no better macos runners available and the intel macos runners are failing for quite some time now we now have little choice other than to stop using macos in the CI.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| set +e | ||
| make test | ||
| status=$? | ||
| # Post a notice only if this is macOS AND tests failed |
Member
There was a problem hiding this comment.
I think we can also remove set +e, status=$?, and exit $status right? So go back to the status before #2715.
BenjaminBossan
approved these changes
Nov 13, 2025
Member
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks for taking care, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2431 since there are no better macos runners available and the intel macos runners are failing for quite some time now we now have little choice other than to stop using macos in the CI.