这是indexloc提供的服务，不要输入任何密码
Skip to content

FIX: update deprecated torch_dtype to dtype (fixes #2835) #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2025
Merged

FIX: update deprecated torch_dtype to dtype (fixes #2835) #2837

merged 2 commits into from
Oct 16, 2025

Conversation

@shantanugupta2004
Copy link
Contributor

@shantanugupta2004 shantanugupta2004 commented Oct 14, 2025 •
edited
Loading

Fixes #2835
This PR addresses the deprecation of the torch_dtype argument in favor of dtype. The changes are applied across documentation, examples, and tests to maintain compatibility and ensure future-proofness.

Key changes:

  • Replaced all instances of torch_dtype with dtype.
  • Updated documentation and examples to reflect the new argument.
  • Ensured that tests are updated to use the dtype argument.

@review-notebook-app
Copy link

review-notebook-app bot commented Oct 14, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@shantanugupta2004 shantanugupta2004 mentioned this pull request Oct 14, 2025
Closed
BenjaminBossan
BenjaminBossan requested changes Oct 15, 2025
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this PR to take care of the deprecated torch_dtype argument. I checked the changes and found a couple of instances where the change has to be reverted, but most look good. I haven't checked if you missed anything, but even so, those instances can be updated later.

@shantanugupta2004
Copy link
Contributor Author

shantanugupta2004 commented Oct 15, 2025

I have reverted the files stated above. Please re-review and suggest any changes if required. @BenjaminBossan

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 16, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

BenjaminBossan
BenjaminBossan approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this deprecation, LGTM.

@BenjaminBossan BenjaminBossan merged commit 1a1f972 into huggingface:main Oct 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update deprecated torch_dtype argument

3 participants

@shantanugupta2004 @HuggingFaceDocBuilderDev @BenjaminBossan