Fix xpu accuracy check by changing seed #2829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test:
pytest -rA tests/test_common_gpu.py::PeftGPUCommonTests::test_8bit_merge_lora_with_biasfailed on XPU due to the accuracy check. After investigation, I found it is due to the accident of the seed. To prove it, I selected seeds from 0 to 100 and see if the accuracy can pass.Output on CUDA (A100):
Output on XPU:
So I select a different seed so the XPU and CUDA checks can all pass.
Hi @BenjaminBossan . Would you please review this PR? Thanks!
cc @yao-matrix