fix dequantize bnb weight on CPU #2820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
@jiqing-feng Could you please run |
Contributor
Author
Done, please review it. Thx. |
BenjaminBossan
approved these changes
Oct 10, 2025
Member
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks for simplifying the dequantization logic. Indeed, it is not required to move the weight to the accelerator first. I think it was at some point, which is why the code is there, but I tested the last few bnb versions and they all worked with the new code, so we should be good.
The failing tests on the CI are unrelated and can be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has no need to check cpu specifically as CPU support dequantize bnb weights.
Hi @BenjaminBossan . Could you please review this PR? Thanks!
cc @yao-matrix