这是indexloc提供的服务，不要输入任何密码
Skip to content

ENH Small speedups to adapter injection #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

ENH Small speedups to adapter injection #2785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/peft/tuners/tuners_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,10 +530,9 @@ def inject_adapter(
and (len(peft_config.target_modules) >= MIN_TARGET_MODULES_FOR_OPTIMIZATION)
and (peft_config.peft_type != PeftType.IA3)
):
suffixes = tuple("." + suffix for suffix in peft_config.target_modules)
names_no_target = [
name
for name in key_list
if not any((name == suffix) or name.endswith("." + suffix) for suffix in peft_config.target_modules)
name for name in key_list if (name not in peft_config.target_modules) and not name.endswith(suffixes)
]
new_target_modules = _find_minimal_target_modules(peft_config.target_modules, names_no_target)
if len(new_target_modules) < len(peft_config.target_modules):
Expand All @@ -543,10 +542,10 @@ def inject_adapter(
# MATCHING & CREATING MODULES #
###############################

existing_adapter_map = {}
existing_adapter_prefixes = []
for key, module in named_modules:
if isinstance(module, BaseTunerLayer):
existing_adapter_map[key] = module
existing_adapter_prefixes.append(key + ".")

# TODO: check if this the most robust way
module_names: set[str] = set()
Expand All @@ -560,8 +559,8 @@ def inject_adapter(

# It is possible that we're adding an additional adapter, so if we encounter a key that clearly belongs to a
# previous adapter we can skip here since we don't want to interfere with adapter internals.
for adapter_key in existing_adapter_map:
if key.startswith(adapter_key + "."):
for adapter_key in existing_adapter_prefixes:
if key.startswith(adapter_key):
excluded_modules.append(key)
break

Expand Down
Loading