enable oft-dreambooth on xpu, and fix example bugs, pass #2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
yao-matrix
commented
Aug 6, 2025
| parser.add_argument("--oft_r", type=int, default=8, help="OFT rank, only used if use_oft is True") | ||
| parser.add_argument("--oft_alpha", type=int, default=32, help="OFT alpha, only used if use_oft is True") | ||
| parser.add_argument("--oft_r", type=int, default=0, help="OFT rank, only used if use_oft is True") | ||
| parser.add_argument("--oft_block_size", type=int, default=32, help="OFT block size, only used if use_oft is True") |
Contributor
Author
There was a problem hiding this comment.
oft doesn't have alpha, it's oft_block_size, and align default value of r to OFTConfig
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Aug 7, 2025
Member
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks for making the OFT dreambooth examples work with XPU and for fixing the argument name issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BenjaminBossan, pls help review, thx very much