Use hub_online_once in trainable token tests
#2701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a minor import nit where `TrainableTokensWrapper` was not added to `utils/__init__.py`. Fixed the corresponding imports as well.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
added 2 commits
August 4, 2025 16:48
It doesn't make sense to change the name from accesses to cache since the former is more descriptive. Sorry for the noise.
BenjaminBossan
approved these changes
Aug 5, 2025
Member
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks for extending the usage and clean ups, LGTM and can be merged.
Just a nit: Do you want to document the potential issue with yield fixtures and hub_online_once directly in the hub_online_once docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a minor import nit where
TrainableTokensWrapperwas not added toutils/__init__.py. Fixed the corresponding imports as well.Another housekeeping job is to move
hub_online_oncetotesting_utils.pysince it has grown to be used in a lot of places andtesting_utils.pyis the better place to keep such utilities.