FIX X-LoRA forward hook issue during generate #2761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue that forward hooks would accumulate during generation, since one hook per forward step was being registered and generate would call forward multiple times. This is already undesirable, but to make it worse, only the last hook was removed, resulting in hooks accumulating. This PR fixes the issue. See huggingface#1472 (comment)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Closed
githubnemo
approved these changes
Sep 1, 2025
Collaborator
githubnemo
left a comment
There was a problem hiding this comment.
LGTM, one question about fixing existing code
src/peft/tuners/xlora/model.py
Outdated
| if not self.disabled: | ||
| # TODO(EricLBuehler): If we get a forward exception, we may have multiple forward hooks. | ||
| for handle in handles_to_remove: | ||
| for handle in hook_handles: |
Collaborator
There was a problem hiding this comment.
Can we remove this todo by wrapping the yield in try: yield; except: raise; finally: remove_hooks?
Member
Author
|
@githubnemo I added |
githubnemo
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue that forward hooks would accumulate during generation, since one hook per forward step was being registered and generate would call
forwardmultiple times. This is already undesirable, but to make it worse, only the last hook was removed, resulting in hooks accumulating.This PR fixes the issue.
See #1472 (comment)