[DOC] update description for BOFT under Adapters conceptual guide #2744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: In CONCEPTUAL GUIDES -> Adapters OFT and BOFT have the same description Solution: Update the description for BOFT from https://arxiv.org/abs/2311.06243
Member
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks for updating the BOFT docs. Generally, this looks good, I just have two smaller comments.
Pinging @zqiu24 again in case you have time to review too.
BenjaminBossan
approved these changes
Aug 19, 2025
Member
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks for updating the wording, to me it's much clearer now. Overall, the PR looks good from my side. I'll merge in one week if we don't hear back from Zeju by then.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
As there was no further feedback in the last week, let's go ahead and merge the change. Once again, thanks @rojagtap for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: In CONCEPTUAL GUIDES -> Adapters OFT and BOFT have the same description
Solution: Update the description for BOFT based on https://arxiv.org/abs/2311.06243
Testing: Verified by building and running doc preview locally:
Issue: #2688
@BenjaminBossan @zqiu24 requesting your review