add a asdict for dataclass model_config #2641
Conversation
|
Yes, I planned to do this as a follow-up to a potential discussion of huggingface/lerobot#1411 but I think it doesn't hurt to support dataclasses as model config objects, especially since the change is not that big. Could you just add a unit test for this case in |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
|
@xliu0105 are you still interested in implementing this? |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
The
get_model_configfunction intuners_utils.pydoes not handle model_config of dataclass data type, because some models (such as the lerobot model) haveconfigattributes, but the dataclass type cannot be converted into a dictionary in theget_model_config function, resulting in an error when using.getin the_get_tied_target_modulesfunction.I fixed this problem. Make peft adapt to a wider range of model types.