这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix: correct macOS version checks. #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Fix: correct macOS version checks. #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,21 +42,18 @@ async function getDownloadFileName() {

case "darwin":

if(parseInt(os.release()) >= 24) {

switch(process.arch) {
switch(process.arch) {

case "x64":
case "x64":

return "ffmpeg-darwin-x86_64.tar.gz";
return "ffmpeg-darwin-x86_64.tar.gz";

case "arm64":
case "arm64":

return "ffmpeg-darwin-arm64.tar.gz";
return "ffmpeg-darwin-arm64.tar.gz";

default:
return null;
}
default:
return null;
}

case "linux":
Expand Down Expand Up @@ -225,7 +222,7 @@ async function install() {
ensureFfmpegCacheDir();

// Ensure we don't support versions of macOS that are too old.
if(os.platform() === "darwin" && parseInt(os.release()) < MACOS_MINIMUM_SUPPORTED_VERSION) {
if((os.platform().toString() === "darwin") && (parseInt(os.release().split(".")[0]) < MACOS_MINIMUM_SUPPORTED_VERSION)) {

console.error("ffmpeg-for-homebridge: macOS versions older than " + MACOS_MINIMUM_SUPPORTED_RELEASE + " are not supported, you will need to install a working version of FFmpeg manually.");

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ffmpeg-for-homebridge",
"version": "2.1.6",
"version": "2.1.7",
"description": "Static FFmpeg binaries for Homebridge with support for audio (libfdk-aac) and hardware encoding (h264_v4l2m2m and h264_qsv).",
"author": {
"name": "The Homebridge Team",
Expand Down