In the event of a successful request, don't fire a timeout later. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewise, in the event of a timeout, don't fire a 'success' if it happens to come in while processing the timeout (much less likely).
Owner
|
Hi Zach, I think we could solve this with less code, could you pls take a look at 7acc683? |
Author
|
The only potential problem I see with not clearing the timeout is that if calling cb() takes longer than the timeout duration, both could still get called. Not sure if that's worth worrying about. Having said that, I'm 99% sure 7acc683 will fix the problem I was seeing (I won't be able to test until Tuesday) and I'm happy to go with it. |
Owner
|
replaced by bed88d5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likewise, in the event of a timeout, don't fire a 'success' if it happens to come in while processing the timeout (much less likely).
I think this is a bug -- in my experience, the old version will always fire a timeout after 15s, even when the request completes successfully. What do you think? Feel free to accept/decline/discuss as you deem appropriate.