You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we want to add back a dependency on libc. Instead, we should copy the definition of gethostname() that libc is using.
@djc Copying the definition of gethostname() that libc is using would work on Linux systems, but I don't see how it would work on macOS without relying on a syscall since macOS doesn't store the host name in a static, readable file. Or do you want to support only Linux systems?
I don't think we want to add back a dependency on libc. Instead, we should copy the definition of gethostname() that libc is using.
@djc Copying the definition of gethostname() that libc is using would work on Linux systems, but I don't see how it would work on macOS without relying on a syscall since macOS doesn't store the host name in a static, readable file. Or do you want to support only Linux systems?
Well, we could make it conditional on the target requiring static linking similar to the stuff that David mentioned in the issue right? We can use the current approach on macOS I think? Or do you need static linking on macOS?
Well, we could make it conditional on the target requiring static linking similar to the stuff that David mentioned in the issue right? We can use the current approach on macOS I think? Or do you need static linking on macOS?
I don't see how it would be possible to statically link on macOS. I will go with the conditional approach based on the target.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#44 has introduced a regression that breaks building statically linked applications that depend on
resolv-confas explained in #49.This PR
gethostnamefromlibccrate to solve the issue with static builds,Note that since now there is an optional dependency on
libc, I putget_system_domainbehindsystemfeature to avoid pulling it when it's not needed.