这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@jordanshatford
Copy link
Contributor

closes: #382

@jordanshatford jordanshatford requested a review from mrlubos April 15, 2024 22:52
@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 90c383a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 0:01am

@codecov
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.08%. Comparing base (a9a8783) to head (90c383a).

Files Patch % Lines
...pi-ts/src/openApi/v2/parser/getModelComposition.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files          74       74           
  Lines        5155     5155           
  Branches      565      565           
=======================================
  Hits         4180     4180           
  Misses        974      974           
  Partials        1        1           
Flag Coverage Δ
unittests 81.08% <90.47%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update migration docs and mention this change in 0.39.0

@jordanshatford jordanshatford merged commit a2f68f6 into main Apr 16, 2024
@jordanshatford jordanshatford deleted the fix/prefer-unknown-over-any branch April 16, 2024 00:09
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How should noImplicitAny be handled?

3 participants