这是indexloc提供的服务，不要输入任何密码
Skip to content

chore(parser): move service type exports to compiler #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2024
Merged

chore(parser): move service type exports to compiler #341

merged 4 commits into from
Apr 11, 2024

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 11, 2024 •
edited
Loading

Closes #339

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3bf3b5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 3:06am

@codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.26316% with 198 lines in your changes are missing coverage. Please review.

Project coverage is 83.46%. Comparing base (55f8cd3) to head (3bf3b5c).

Files Patch % Lines
packages/openapi-ts/src/utils/write/models.ts 2.46% 158 Missing ⚠️
packages/openapi-ts/src/utils/handlebars.ts 5.12% 37 Missing ⚠️
packages/openapi-ts/src/utils/write/type.ts 25.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   84.85%   83.46%   -1.39%     
==========================================
  Files          74       74              
  Lines        4709     4773      +64     
  Branches      545      546       +1     
==========================================
- Hits         3996     3984      -12     
- Misses        712      788      +76     
  Partials        1        1
Flag Coverage Δ
unittests 83.46% <5.26%> (-1.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos force-pushed the chore/service-types-compiler branch from e3be704 to b2540af Compare April 11, 2024 02:50
@mrlubos mrlubos force-pushed the chore/service-types-compiler branch from b2540af to a772f2e Compare April 11, 2024 02:53
@mrlubos mrlubos force-pushed the chore/service-types-compiler branch from a772f2e to eee1dfa Compare April 11, 2024 02:56
@mrlubos mrlubos force-pushed the chore/service-types-compiler branch from eee1dfa to 8b59a52 Compare April 11, 2024 03:02
@mrlubos mrlubos force-pushed the chore/service-types-compiler branch 2 times, most recently from c4f2401 to 674d2e7 Compare April 11, 2024 03:03
@mrlubos mrlubos force-pushed the chore/service-types-compiler branch from 674d2e7 to 3bf3b5c Compare April 11, 2024 03:05
@mrlubos mrlubos requested a review from jordanshatford April 11, 2024 03:06
@mrlubos mrlubos marked this pull request as ready for review April 11, 2024 03:06
@mrlubos mrlubos merged commit 44a8f23 into main Apr 11, 2024
@mrlubos mrlubos deleted the chore/service-types-compiler branch April 11, 2024 03:18
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jordanshatford jordanshatford jordanshatford approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicate Model in models.ts

3 participants

@mrlubos @jordanshatford