这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 9, 2024

Fixes #314
Closes #313

@mrlubos mrlubos marked this pull request as ready for review April 9, 2024 16:23
@vercel
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 4:23pm

@codecov
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.82%. Comparing base (80f192e) to head (4e86215).

Files Patch % Lines
packages/openapi-ts/src/utils/write/schemas.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   85.81%   85.82%           
=======================================
  Files          72       72           
  Lines        4619     4621    +2     
  Branches      542      542           
=======================================
+ Hits         3964     3966    +2     
  Misses        654      654           
  Partials        1        1           
Flag Coverage Δ
unittests 85.82% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit b7cde02 into main Apr 9, 2024
@mrlubos mrlubos deleted the fix/escape-schema-names branch April 9, 2024 16:33
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema names are not sanitized when creating variable names

2 participants