这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(@pinia/colada): correctly access instantiated SDKs #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

fix(@pinia/colada): correctly access instantiated SDKs #2942

merged 1 commit into from
Nov 7, 2025

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Nov 7, 2025

No description provided.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Nov 7, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

🦋 Changeset detected

Latest commit: c041e96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review November 7, 2025 19:35
@vercel
Copy link

vercel bot commented Nov 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Nov 7, 2025 7:35pm

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 19.32367% with 334 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.27%. Comparing base (520251d) to head (c041e96).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/ts-dsl/var.ts 20.00% 100 Missing ⚠️
packages/openapi-ts/src/ts-dsl/func.ts 28.84% 74 Missing ⚠️
packages/openapi-ts/src/ts-dsl/base.ts 2.50% 39 Missing ⚠️
.../openapi-ts/src/plugins/@pinia/colada/v0/plugin.ts 3.44% 28 Missing ⚠️
packages/openapi-ts/src/plugins/swr/v2/plugin.ts 3.44% 28 Missing ⚠️
packages/openapi-ts/src/plugins/swr/v2/useSwr.ts 3.84% 25 Missing ⚠️
packages/openapi-ts/src/ts-dsl/index.ts 50.00% 9 Missing ⚠️
...penapi-ts/src/plugins/@hey-api/sdk/shared/class.ts 0.00% 6 Missing ⚠️
packages/openapi-ts/src/ts-dsl/await.ts 53.84% 6 Missing ⚠️
packages/openapi-ts/src/ts-dsl/object.ts 0.00% 6 Missing ⚠️
... and 10 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2942      +/-   ##
==========================================
- Coverage   28.30%   28.27%   -0.03%     
==========================================
  Files         387      389       +2     
  Lines       34989    35223     +234     
  Branches     1964     1933      -31     
==========================================
+ Hits         9902     9959      +57     
- Misses      25060    25237     +177     
  Partials       27       27
Flag Coverage Δ
unittests 28.27% <19.32%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2942

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2942

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2942

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2942

commit: c041e96

@mrlubos mrlubos merged commit 52fbf53 into main Nov 7, 2025
15 of 17 checks passed
@mrlubos mrlubos deleted the chore/dsl-func branch November 7, 2025 19:43
@hey-api hey-api bot mentioned this pull request Nov 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrlubos