这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(sdk): handle conflicts between method names and subclasses in class-based SDKs #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

fix(sdk): handle conflicts between method names and subclasses in class-based SDKs #2920

merged 1 commit into from
Nov 3, 2025

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Nov 3, 2025

Fixes #2815

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Nov 3, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review November 3, 2025 16:50
@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 48c7fa3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Nov 3, 2025 5:19pm

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 3, 2025
@dosubot dosubot bot added bug 🔥 Something isn't working client Client package related labels Nov 3, 2025
@mrlubos mrlubos force-pushed the fix/sdk-as-class-circular branch from c889bda to 5e0a52e Compare November 3, 2025 17:01
@mrlubos mrlubos force-pushed the fix/sdk-as-class-circular branch from 5e0a52e to cdef496 Compare November 3, 2025 17:08
@mrlubos mrlubos force-pushed the fix/sdk-as-class-circular branch from cdef496 to 48c7fa3 Compare November 3, 2025 17:18
@codecov
Copy link

codecov bot commented Nov 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.85%. Comparing base (7e1a276) to head (48c7fa3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...penapi-ts/src/plugins/@hey-api/sdk/shared/class.ts 0.00% 91 Missing ⚠️
packages/openapi-ts/src/tsc/types.ts 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2920      +/-   ##
==========================================
- Coverage   30.89%   30.85%   -0.04%     
==========================================
  Files         488      488              
  Lines       40510    40561      +51     
  Branches     2526     2526              
==========================================
  Hits        12516    12516              
- Misses      27959    28010      +51     
  Partials       35       35
Flag Coverage Δ
unittests 30.85% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2920

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2920

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2920

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2920

commit: 48c7fa3

@mrlubos mrlubos merged commit 66a1588 into main Nov 3, 2025
15 of 17 checks passed
@mrlubos mrlubos deleted the fix/sdk-as-class-circular branch November 3, 2025 17:26
@hey-api hey-api bot mentioned this pull request Nov 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug 🔥 Something isn't working client Client package related size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded when using asClass: true

2 participants

@mrlubos