Fix placeholder replacement for external symbols without names #2916
+136
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen was outputting invalid
_heyapi_xxx_identifiers in generated code when external symbols (e.g., zod'sz) were referenced before registration, leaving placeholders unreplaced.Root Cause
When
referenceSymbol()creates stubs for external symbols, they lack anameproperty. During rendering,replacerFnreturnsundefinedfor nameless symbols, causingrenderIdsto preserve placeholders in output.Changes
meta.resourcewhennameis undefined{ resource: 'zod.z' }→ extracts'z'Example
Before fix:
After fix:
Type-only imports already emit correctly with
import { type Foo }syntax.Original prompt
_heyapi_xxx_identifiers after 0.86 and type‑only imports regressed #2915💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.