这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(tanstack-query): correctly access instantiated SDKs #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2025
Merged

fix(tanstack-query): correctly access instantiated SDKs #2939

merged 3 commits into from
Nov 6, 2025

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Nov 6, 2025

No description provided.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Nov 6, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e71647d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Nov 6, 2025 6:52pm

@mrlubos mrlubos marked this pull request as ready for review November 6, 2025 18:26
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 6, 2025
@dosubot dosubot bot added bug 🔥 Something isn't working client Client package related labels Nov 6, 2025
@max-scopp
Copy link
Contributor

max-scopp commented Nov 6, 2025

1c281b80-5ec3-4c12-9837-56eba7f71de6_text-2777939929

@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 28.38802% with 1506 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.30%. Comparing base (7b224f8) to head (e71647d).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...penapi-ts/src/plugins/@hey-api/sdk/shared/class.ts 1.87% 262 Missing ⚠️
...i-ts/src/plugins/@tanstack/query-core/v5/plugin.ts 5.88% 128 Missing ⚠️
.../openapi-ts/src/plugins/@pinia/colada/v0/plugin.ts 4.95% 96 Missing ⚠️
packages/openapi-ts/src/ts-dsl/type.ts 38.23% 84 Missing ⚠️
packages/openapi-ts/src/plugins/swr/v2/useSwr.ts 4.59% 83 Missing ⚠️
packages/openapi-ts/src/ts-dsl/base.ts 12.32% 64 Missing ⚠️
packages/openapi-ts/src/ts-dsl/template.ts 12.50% 63 Missing ⚠️
packages/openapi-ts/src/plugins/swr/v2/plugin.ts 6.55% 57 Missing ⚠️
packages/openapi-ts/src/ts-dsl/binary.ts 14.03% 49 Missing ⚠️
packages/openapi-ts/src/ts-dsl/describe.ts 15.51% 49 Missing ⚠️
... and 37 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2939      +/-   ##
==========================================
+ Coverage   27.95%   28.30%   +0.34%     
==========================================
  Files         346      387      +41     
  Lines       33374    34989    +1615     
  Branches     1921     1964      +43     
==========================================
+ Hits         9330     9902     +572     
- Misses      24017    25060    +1043     
  Partials       27       27
Flag Coverage Δ
unittests 28.30% <28.38%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2939

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2939

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2939

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2939

commit: e71647d

@mrlubos mrlubos merged commit 1cbf85f into main Nov 6, 2025
17 checks passed
@mrlubos mrlubos deleted the feat/sdk-plugin-tanstack branch November 6, 2025 19:00
@hey-api hey-api bot mentioned this pull request Nov 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug 🔥 Something isn't working client Client package related size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrlubos @max-scopp