这是indexloc提供的服务，不要输入任何密码
Skip to content

Swap order of format and lint processing #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2025
Merged

Swap order of format and lint processing #2937

merged 3 commits into from
Nov 11, 2025

Conversation

@FloEdelmann
Copy link
Contributor

@FloEdelmann FloEdelmann commented Nov 6, 2025

Fixes #2200.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Nov 6, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 4fac7d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 6, 2025

@FloEdelmann is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 6, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug 🔥 Something isn't working and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.41%. Comparing base (7b224f8) to head (4fac7d2).
⚠️ Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/processOutput.ts 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2937      +/-   ##
==========================================
+ Coverage   27.95%   29.41%   +1.46%     
==========================================
  Files         346      403      +57     
  Lines       33374    35766    +2392     
  Branches     1921     2065     +144     
==========================================
+ Hits         9330    10522    +1192     
- Misses      24017    25217    +1200     
  Partials       27       27
Flag Coverage Δ
unittests 29.41% <0.00%> (+1.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2937

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2937

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2937

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2937

commit: eb23ee8

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2025
@mrlubos mrlubos merged commit c53f515 into hey-api:main Nov 11, 2025
13 of 15 checks passed
@FloEdelmann FloEdelmann deleted the patch-1 branch November 11, 2025 14:18
@hey-api hey-api bot mentioned this pull request Nov 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrlubos mrlubos mrlubos approved these changes

Assignees

No one assigned

Labels

bug 🔥 Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow changing the Order of ESLint and Prettier being applied

2 participants

@FloEdelmann @mrlubos