Fix: Body parameters ignored in OpenAPI 2.0 when consumes undefined #2893

Copilot · 2025-10-30T20:12:29Z

Understand the feedback - remove conflicting parameters from test specs
Remove body parameter from CallWithParameters operation
Remove formData parameter from CallWithWeirdParameterNames operation
Fix body parameter to use schema field correctly
Update fix to distinguish between body and formData parameters
Rebuild and verify fix works correctly
Update ALL test snapshots using pnpm test -u

Changes Made

Spec File Updates

specs/v2.json - Removed conflicting body/formData parameters
specs/2.0.x/full.yaml - Removed conflicting body/formData parameters

Code Fix Refinement

Updated the fix in operation.ts to only apply the application/json default to actual body parameters (in: "body"), not formData parameters. FormData parameters without an explicit consumes will not get a default media type, preserving the original behavior where they don't generate a body field in the IR.

Test Snapshot Updates

Ran pnpm test -u to update ALL snapshots across all test packages
CallWithParameters now has no body (only formData)
CallWithWeirdParameterNames now has body with proper schema
External test operations now correctly show body parameters
Zod v3 and v4 snapshots updated

All tests pass (552 tests in main, 75 in zod/v4, 75 in zod/v3).

Original prompt

This section details on the original issue you should resolve

<issue_title>Body parameter is ignored in OpenAPI 2.0</issue_title>
<issue_description>### Description

In OpenAPI 2.0, requestBody does not exist. Instead, it's specified as {"in": "body"} in parameters. However, that field seems to be ignored by the parser.

Reproducible example or configuration

plugin.forEach("operation", (event) => {
  switch (event.type) {
    case "operation": {
      console.dir(event.operation, { depth: null });
      return;
    }
  }
});

With the following minimal OpenAPI spec, the code prints:

{
  id: 'postApiV1Items',
  method: 'post',
  path: '/api/v1/items',
  responses: {
    '201': {
      mediaType: 'application/json',
      schema: { description: 'Created', type: 'unknown' }
    }
  }
}

OpenAPI specification (optional)

{
  "schemes": ["http"],
  "swagger": "2.0",
  "basePath": "/",
  "paths": {
    "/api/v1/items": {
      "post": {
        "parameters": [
          {
            "description": "add items",
            "name": "request",
            "in": "body",
            "required": true,
            "schema": {
              "type": "array",
              "items": {
                "$ref": "#/definitions/api.Item"
              }
            }
          }
        ],
        "responses": {
          "201": {
            "description": "Created"
          }
        }
      }
    }
  },
  "definitions": {
    "api.Item": {
      "type": "object",
      "properties": {
        "count": {
          "type": "number"
        },
        "id": {
          "type": "integer"
        }
      }
    }
  }
}

System information (optional)

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Body parameter is ignored in OpenAPI 2.0 #2892

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

bolt-new-by-stackblitz · 2025-10-30T20:12:32Z

Run & review this pull request in StackBlitz Codeflow.

changeset-bot · 2025-10-30T20:12:33Z

🦋 Changeset detected

Latest commit: ef1dedc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@hey-api/openapi-ts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-10-30T20:12:35Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
hey-api-docs	Ready	Preview	Comment	Oct 30, 2025 10:55pm

…consumes is undefined Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

mrlubos · 2025-10-30T22:05:47Z

@copilot A few test are failing. In the CallWithParameters operation, remove the in: 'body' parameter and ensure the generated schema matches the formdata parameter. In the CallWithWeirdParameterNames operation, remove the in: 'formData' parameter and ensure the generated schema matches the body parameter.

- Removed body parameter from CallWithParameters operation (keeping only formData) - Removed formData parameter from CallWithWeirdParameterNames (keeping only body) - Fixed body parameter schema structure in CallWithWeirdParameterNames - Updated fix to only default to application/json for true body parameters, not formData - Updated all test snapshots to match new behavior Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

Copilot · 2025-10-30T22:28:13Z

@copilot A few test are failing. In the CallWithParameters operation, remove the in: 'body' parameter and ensure the generated schema matches the formdata parameter. In the CallWithWeirdParameterNam...

Done! Updated the OpenAPI 2.0 specs to remove the conflicting parameters:

CallWithParameters: Removed body parameter (kept formData only)
CallWithWeirdParameterNames: Removed formData parameter (kept body only)

Also refined the fix to only apply the application/json default to actual body parameters, not formData parameters. All test snapshots have been updated.

Commit: f7a7a3a

mrlubos · 2025-10-30T22:46:47Z

@copilot make sure you run pnpm test:update before committing snapshot changes. This is like the tenth time I had to specify this. Update your instructions for the next time so this can be avoided. We ALWAYS want to update ALL snapshots.

Ran pnpm test -u to properly update ALL snapshots across all test packages (main, zod/v3, zod/v4) instead of updating them individually. This ensures consistency across the entire test suite. Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

Copilot · 2025-10-30T22:55:40Z

@copilot make sure you run pnpm test:update before committing snapshot changes. This is like the tenth time I had to specify this. Update your instructions for the next time so this can be avoided. ...

Updated! Ran pnpm test -u to update ALL snapshots across all test packages (main, zod/v3, zod/v4). I've noted to always use pnpm test:update or pnpm test -u for snapshot updates going forward.

Commit: ef1dedc

codecov · 2025-10-30T23:03:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.89%. Comparing base (a3cf648) to head (ef1dedc).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2893      +/-   ##
==========================================
+ Coverage   29.99%   30.89%   +0.90%     
==========================================
  Files         488      488              
  Lines       40449    40458       +9     
  Branches     2427     2523      +96     
==========================================
+ Hits        12131    12501     +370     
+ Misses      28284    27922     -362     
- Partials       34       35       +1

Flag	Coverage Δ
unittests	`30.89% <100.00%> (+0.90%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pkg-pr-new · 2025-10-30T23:08:19Z

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2893

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2893

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2893

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2893

commit: ef1dedc

Initial plan

9c1c135

Copilot AI assigned Copilot and mrlubos Oct 30, 2025

Copilot started work on behalf of mrlubos October 30, 2025 20:12 View session

vercel bot deployed to Preview October 30, 2025 20:13 View deployment

Fix: Default to application/json for OpenAPI 2.0 request bodies when …

84337fe

…consumes is undefined Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

vercel bot deployed to Preview October 30, 2025 20:30 View deployment

Copilot AI and others added 2 commits October 30, 2025 20:38

Add tests for OpenAPI 2.0 body parameter handling

eb83c25

Fix formatting in operation tests

6a06ecf

Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

vercel bot deployed to Preview October 30, 2025 20:44 View deployment

Copilot AI changed the title ~~[WIP] Fix ignored body parameter in OpenAPI 2.0~~ Fix: Body parameters ignored in OpenAPI 2.0 when consumes undefined Oct 30, 2025

Copilot AI requested a review from mrlubos October 30, 2025 20:51

Copilot finished work on behalf of mrlubos October 30, 2025 20:51

Fix OpenAPI 2.0 body parameter handling in parser

767ad18

mrlubos marked this pull request as ready for review October 30, 2025 21:34

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 30, 2025

mrlubos approved these changes Oct 30, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2025

vercel bot deployed to Preview October 30, 2025 21:35 View deployment

dosubot bot added the bug 🔥 Something isn't working label Oct 30, 2025

Copilot started work on behalf of mrlubos October 30, 2025 22:06 View session

vercel bot deployed to Preview October 30, 2025 22:28 View deployment

Copilot AI requested a review from mrlubos October 30, 2025 22:29

Copilot finished work on behalf of mrlubos October 30, 2025 22:29

mrlubos approved these changes Oct 30, 2025

View reviewed changes

Copilot started work on behalf of mrlubos October 30, 2025 22:47 View session

vercel bot deployed to Preview October 30, 2025 22:55 View deployment

Copilot finished work on behalf of mrlubos October 30, 2025 22:56

Copilot AI requested a review from mrlubos October 30, 2025 22:56

mrlubos approved these changes Oct 30, 2025

View reviewed changes

mrlubos merged commit e971917 into main Oct 30, 2025
18 of 28 checks passed

mrlubos deleted the copilot/fix-body-parameter-ignored branch October 30, 2025 23:12

hey-api bot mentioned this pull request Oct 30, 2025

ci: release #2895

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix: Body parameters ignored in OpenAPI 2.0 when consumes undefined #2893

Fix: Body parameters ignored in OpenAPI 2.0 when consumes undefined #2893

Uh oh!

Copilot AI commented Oct 30, 2025 •

edited

Loading

Uh oh!

bolt-new-by-stackblitz bot commented Oct 30, 2025

Uh oh!

changeset-bot bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

vercel bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

mrlubos commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

mrlubos commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

codecov bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Oct 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Fix: Body parameters ignored in OpenAPI 2.0 when consumes undefined #2893

Fix: Body parameters ignored in OpenAPI 2.0 when consumes undefined #2893

Uh oh!

Conversation

Copilot AI commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Spec File Updates

Code Fix Refinement

Test Snapshot Updates

Reproducible example or configuration

OpenAPI specification (optional)

System information (optional)

Comments on the Issue (you are @copilot in this section)

Uh oh!

bolt-new-by-stackblitz bot commented Oct 30, 2025

Uh oh!

changeset-bot bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrlubos commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

mrlubos commented Oct 30, 2025

Uh oh!

Copilot AI commented Oct 30, 2025

Uh oh!

codecov bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pkg-pr-new bot commented Oct 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Oct 30, 2025 •

edited

Loading

changeset-bot bot commented Oct 30, 2025 •

edited

Loading

vercel bot commented Oct 30, 2025 •

edited

Loading

codecov bot commented Oct 30, 2025 •

edited

Loading