这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@MuzzaiyyanHussain
Copy link

This PR fixes an issue in the Valibot plugin where string schemas with an isoTime format were not properly handled or validated.

Summary

Added missing v1/index.ts export to ensure proper module resolution (Cannot find module './v1' issue fixed).

Updated toAst/string.ts to correctly process and validate ISO time strings.

Adjusted index.ts references and ensured consistent plugin imports.

Updated related test cases in cli.test.ts to verify the fix.

Test Files 12 passed (12)
Tests 617 passed (617)
Duration ~59s

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

⚠️ No Changeset found

Latest commit: b92f97a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 30, 2025

@MuzzaiyyanHussain is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug 🔥 Something isn't working javascript Pull requests that update Javascript code labels Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.01%. Comparing base (c6de684) to head (b92f97a).

Files with missing lines Patch % Lines
.../openapi-ts/src/plugins/valibot/v1/toAst/string.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2890   +/-   ##
=======================================
  Coverage   30.01%   30.01%           
=======================================
  Files         488      489    +1     
  Lines       40423    40436   +13     
  Branches     2427     2427           
=======================================
+ Hits        12131    12135    +4     
- Misses      28258    28267    +9     
  Partials       34       34           
Flag Coverage Δ
unittests 30.01% <28.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos
Copy link
Member

mrlubos commented Oct 30, 2025

@MuzzaiyyanHussain #2889 :)

@mrlubos mrlubos closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔥 Something isn't working javascript Pull requests that update Javascript code size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants