这是indexloc提供的服务，不要输入任何密码
Skip to content

refactor: remove selectors from typescript plugin #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

refactor: remove selectors from typescript plugin #2878

merged 2 commits into from
Oct 29, 2025

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Oct 29, 2025

No description provided.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Oct 29, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d3a7811

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Oct 29, 2025 1:05pm

@mrlubos mrlubos marked this pull request as ready for review October 29, 2025 12:54
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 29, 2025
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 2.46575% with 356 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.33%. Comparing base (830a26a) to head (d3a7811).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/plugins/zod/mini/plugin.ts 0.00% 25 Missing ⚠️
packages/openapi-ts/src/plugins/zod/v3/plugin.ts 0.00% 25 Missing ⚠️
packages/openapi-ts/src/plugins/zod/v4/plugin.ts 0.00% 25 Missing ⚠️
...ges/openapi-ts/src/plugins/zod/shared/operation.ts 0.00% 22 Missing ⚠️
...src/plugins/@hey-api/typescript/v1/toAst/string.ts 0.00% 18 Missing ⚠️
packages/openapi-ts/src/plugins/zod/mini/api.ts 0.00% 14 Missing ⚠️
packages/openapi-ts/src/plugins/zod/v3/api.ts 0.00% 14 Missing ⚠️
packages/openapi-ts/src/plugins/zod/v4/api.ts 0.00% 14 Missing ⚠️
.../src/plugins/@hey-api/typescript/shared/webhook.ts 0.00% 11 Missing ⚠️
...kages/openapi-ts/src/plugins/zod/shared/webhook.ts 0.00% 11 Missing ⚠️
... and 46 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2878      +/-   ##
==========================================
- Coverage   30.53%   30.33%   -0.20%     
==========================================
  Files         488      488              
  Lines       39996    40246     +250     
  Branches     2441     2438       -3     
==========================================
- Hits        12213    12209       -4     
- Misses      27749    28003     +254     
  Partials       34       34
Flag Coverage Δ
unittests 30.33% <2.46%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 29, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2878

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2878

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2878

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2878

commit: d3a7811

@mrlubos mrlubos merged commit dfd1a2e into main Oct 29, 2025
15 of 17 checks passed
@mrlubos mrlubos deleted the refactor/selector-typescript branch October 29, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

javascript Pull requests that update Javascript code size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrlubos