这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(client-axios): Fix axios error handling without ts errors #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

fix(client-axios): Fix axios error handling without ts errors #2821

wants to merge 14 commits into from

Conversation

@mauriciabad
Copy link
Contributor

@mauriciabad mauriciabad commented Oct 23, 2025

Reverts #2804 and fixes #2800

Basically it's the original PR #2763 with TS errors fixed.

Note that I just fixed the TS errors introduced in the original PR, these errors are not related to the reverted PR.
Screenshot 2025-10-23 at 12 47 51 PM

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Oct 23, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e5bf992

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 23, 2025
@vercel
Copy link

vercel bot commented Oct 23, 2025

@mauriciabad is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added bug 🔥 Something isn't working client Client package related labels Oct 23, 2025
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 23, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 23, 2025
@mauriciabad mauriciabad changed the title Fix axios error handling without ts errors fix(client-axios): Fix axios error handling without ts errors Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.41%. Comparing base (6228211) to head (e5bf992).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2821      +/-   ##
==========================================
+ Coverage   30.39%   30.41%   +0.01%     
==========================================
  Files         420      420              
  Lines       35415    35418       +3     
  Branches     2083     2089       +6     
==========================================
+ Hits        10765    10772       +7     
+ Misses      24623    24619       -4     
  Partials       27       27
Flag Coverage Δ
unittests 30.41% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 23, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2821

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2821

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2821

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2821

commit: e5bf992

@mrlubos mrlubos mentioned this pull request Oct 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug 🔥 Something isn't working client Client package related size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Property 'error' does not exist on type 'object'

1 participant

@mauriciabad