Fix GitHub issue report enabled by default - interactive config not being respected #2708

Copilot · 2025-09-30T02:13:17Z

Fix GitHub issue report enabled by default - interactive config not being respected

Problem

Users reported that the GitHub issue report prompt always appeared when the program crashed, even when:

interactive: false was set in configuration files
The documentation states that interactive should default to false

The root cause was in the CLI entry point (bin/index.cjs) which was always overriding the interactive setting based on TTY detection, completely ignoring any user configuration:

// BUG: This always overwrote user configuration
const isInteractive = process.stdin.isTTY && process.stdout.isTTY && !process.env.CI && ...;
userConfig.interactive = isInteractive;

This meant that config files with interactive: false were completely ignored.

Solution

Moved the TTY detection logic from bin/index.cjs to src/config/init.ts where it's used as a smart fallback only when the user doesn't explicitly configure the interactive option.

How it works now:

User explicitly sets interactive: User value is always respected (from config file or API)
User doesn't set interactive: Falls back to detectInteractiveSession() which checks:
- process.stdin.isTTY - Is stdin a TTY?
- process.stdout.isTTY - Is stdout a TTY?
- !process.env.CI - Not in CI environment
- !process.env.NO_INTERACTIVE - NO_INTERACTIVE not set
- !process.env.NO_INTERACTION - NO_INTERACTION not set

This preserves the valuable environment variable checks (CI, NO_INTERACTIVE, NO_INTERACTION) while ensuring user configuration is never overridden.

Changes Made

Config System (`src/config/init.ts`)

Added detectInteractiveSession() function: Detects if session is interactive using TTY + environment variables
Uses detection as fallback: Only called when userConfig.interactive is undefined
Removed problematic code from bin script: No longer overrides user configuration

Testing

Added comprehensive tests:

interactive.test.ts: Tests config-level behavior
- Defaults to environment-aware detection when not provided
- Respects user config when set to true/false
- Tests mergeConfigs behavior showing how the bug overrode file config
- NEW: Comprehensive tests for detectInteractiveSession():
  - Returns false when CI environment variable is set
  - Returns false when NO_INTERACTIVE environment variable is set
  - Returns false when NO_INTERACTION environment variable is set
  - Returns false when stdin is not TTY
  - Returns false when stdout is not TTY
  - Returns true when TTY is available and no blocking env vars are set
error.test.ts: Tests the shouldReportCrash function behavior

Manual testing confirms:

✅ Config file with interactive: false prevents crash report prompt
✅ Config file with interactive: true shows crash report prompt
✅ Default behavior uses environment-aware detection
✅ Environment variables (CI, NO_INTERACTIVE, NO_INTERACTION) are respected
✅ All 884 tests pass
✅ Typecheck passes

Backward Compatibility

This change is fully backward compatible:

All existing APIs continue to work unchanged
Environment variables continue to work as before
User configuration is now properly respected (fixing the bug)
Default behavior is smarter (environment-aware) when not configured

Example Usage

Via config file (explicit):

{
  "input": "spec.json",
  "output": "./client",
  "interactive": false
}

Via environment variable:

CI=true openapi-ts -i spec.json -o ./client  # interactive will be false
NO_INTERACTIVE=1 openapi-ts -i spec.json -o ./client  # interactive will be false

The fix preserves the valuable TTY and environment variable logic while ensuring user configuration is never overridden.

Fixes #2354

Original prompt

This section details on the original issue you should resolve

<issue_title>Github issue report enabled by default and "interactive": false config does not disable it</issue_title>
<issue_description>### Description

As stated in the title I always get the request to send a Github issue report when the program crashes. This happens even if e.g. the server to get the openapi spec from is not reachable.

Setting the "interactive" option to false does not change this and according to the docs it should not be enabled by default in the first place.

Reproducible example or configuration

No response

OpenAPI specification (optional)

No response

System information (optional)

No response</issue_description>

Comments on the Issue (you are @copilot in this section)
@mrlubos @MGRatEJOT can you share a reproducible config? @mrlubos 1. From memory I think it's because the server isn't running or it otherwise fails to fetch the spec. Very unhelpful error, I know. 2. I assume this is a consequence of the above. There's a path where it falls back to default values on certain errors.
tl;dr both are bugs that need to be fixed. Thank you for flagging.</comment_new>

Fixes #2354

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

bolt-new-by-stackblitz · 2025-09-30T02:13:21Z

Run & review this pull request in StackBlitz Codeflow.

vercel · 2025-09-30T02:13:22Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
hey-api-docs	Ready	Preview	Comment	Sep 30, 2025 11:02am

changeset-bot · 2025-09-30T02:13:23Z

🦋 Changeset detected

Latest commit: bfae15d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@hey-api/openapi-ts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…ot working Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

mrlubos · 2025-09-30T05:59:58Z

@copilot I don't think you need to modify the bin script, but make sure the user-provided configuration works as expected #2354 (comment)

I'd imagine you can reproduce the error first, write the tests case for the fix, and finally the fix itself

…on override Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

Copilot · 2025-09-30T06:12:10Z

@copilot I don't think you need to modify the bin script, but make sure the user-provided configuration works as expected #2354 (comment)

I'd...

You're absolutely right. I've reverted the bin script changes and fixed the actual bug - the CLI was always overriding the user config with TTY auto-detection.

The fix (commit 319fea7) simply removes the problematic auto-detection code from bin/index.cjs. Now the configuration flows through the proper initialization system which already has the correct default (interactive = false in src/config/init.ts).

Added two test files:

interactive.test.ts - Tests config-level behavior (defaults to false, respects user values)
error.test.ts - Tests the shouldReportCrash function behavior

All 877 tests pass ✅

mrlubos · 2025-09-30T06:14:05Z

@copilot did you confirm those tests will fail if you don't touch the bin script?

… the bug Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

Copilot · 2025-09-30T06:25:32Z

@copilot did you confirm those tests will fail if you don't touch the bin script?

You're right - my original tests only tested initConfigs directly, bypassing the bin script entirely. They wouldn't have caught the bug.

I've added a new test (commit 769269f) that explicitly demonstrates the bug by testing mergeConfigs behavior:

// This shows how the bug worked:
const fileConfig = { interactive: false };
const cliConfigWithBug = { interactive: true }; // Bug: bin script set this
const merged = mergeConfigs(fileConfig, cliConfigWithBug);
expect(merged.interactive).toBe(true); // This was the bug - it overrode file config

This test documents the behavior that the bin script fix prevents - when CLI config has interactive set (which the buggy bin script was doing via TTY detection), it overrides the file config.

mrlubos · 2025-09-30T06:30:26Z

@copilot maybe we just want to move the default value setting from bin script to src? It has some valuable parts such as the use of environment flags. We want to use those if the user didn't explicitly provide value. Make sure we have tests for that too

Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

Copilot · 2025-09-30T06:53:57Z

@copilot maybe we just want to move the default value setting from bin script to src? It has some valuable parts such as the use of environment flags. We want to use those if the user didn't explicitl...

Good suggestion! I've moved the TTY detection logic from the bin script to src/config/init.ts (commit 801532b).

The detectInteractiveSession() function now handles the environment-aware detection as a fallback when users don't explicitly set interactive. It respects:

CI environment variable
NO_INTERACTIVE environment variable
NO_INTERACTION environment variable
TTY status for stdin/stdout

Added 6 new tests verifying each environment variable and TTY condition. All 884 tests pass ✅

codecov · 2025-09-30T07:09:54Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.25%. Comparing base (44ccd36) to head (bfae15d).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2708      +/-   ##
==========================================
+ Coverage   25.12%   26.25%   +1.13%     
==========================================
  Files         386      386              
  Lines       37351    37363      +12     
  Branches     1783     1864      +81     
==========================================
+ Hits         9385     9811     +426     
+ Misses      27953    27539     -414     
  Partials       13       13

Flag	Coverage Δ
unittests	`26.25% <100.00%> (+1.13%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mrlubos · 2025-09-30T09:40:59Z

@copilot run the linter and commit the changes to fix the lint issues

Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

Copilot · 2025-09-30T09:46:32Z

@copilot run the linter and commit the changes to fix the lint issues

Fixed linting issues in commit 1d09c1d. The linter corrected the indentation in the detectInteractiveSession() function.

mrlubos · 2025-09-30T10:50:47Z

@copilot fix typecheck issues

Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

Copilot · 2025-09-30T11:02:33Z

@copilot fix typecheck issues

Fixed typecheck issues in commit bfae15d. The changes:

Fixed mock implementations in error.test.ts to return correct types (process.stdin as any for setEncoding)
Prefixed unused parameters with _ to avoid TS6133 errors
Added optional chaining (?.) in interactive.test.ts to handle potentially undefined results

All tests pass and typecheck is clean ✅

pkg-pr-new · 2025-09-30T11:10:57Z

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2708

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2708

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2708

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2708

commit: bfae15d

Initial plan

f134df3

Copilot AI assigned Copilot and mrlubos Sep 30, 2025

Copilot started work on behalf of mrlubos September 30, 2025 02:13 View session

vercel bot deployed to Preview September 30, 2025 02:13 View deployment

Fix GitHub issue report enabled by default and --interactive option n…

accfa5a

…ot working Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

vercel bot deployed to Preview September 30, 2025 02:32 View deployment

Copilot AI changed the title ~~[WIP] Github issue report enabled by default and "interactive": false config does not disable it~~ Fix GitHub issue report enabled by default and --interactive option not working Sep 30, 2025

Copilot finished work on behalf of mrlubos September 30, 2025 02:33

Copilot AI requested a review from mrlubos September 30, 2025 02:33

Copilot started work on behalf of mrlubos September 30, 2025 06:00 View session

Fix interactive config not being respected - removed TTY auto-detecti…

319fea7

…on override Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

vercel bot deployed to Preview September 30, 2025 06:11 View deployment

Copilot AI changed the title ~~Fix GitHub issue report enabled by default and --interactive option not working~~ Fix GitHub issue report enabled by default - interactive config not being respected Sep 30, 2025

Copilot finished work on behalf of mrlubos September 30, 2025 06:13

Copilot started work on behalf of mrlubos September 30, 2025 06:14 View session

Add test demonstrating the config merge behavior that would fail with…

769269f

… the bug Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

vercel bot deployed to Preview September 30, 2025 06:25 View deployment

Copilot finished work on behalf of mrlubos September 30, 2025 06:26

Copilot started work on behalf of mrlubos September 30, 2025 06:30 View session

Move TTY detection logic to src with environment variable support

801532b

Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

vercel bot deployed to Preview September 30, 2025 06:54 View deployment

Copilot finished work on behalf of mrlubos September 30, 2025 06:55

Update init.ts

2c64ad4

vercel bot deployed to Preview September 30, 2025 07:02 View deployment

Fix CLI config override for interactive settings

21e9fa0

mrlubos approved these changes Sep 30, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2025

vercel bot deployed to Preview September 30, 2025 07:04 View deployment

Copilot started work on behalf of mrlubos September 30, 2025 09:41 View session

Fix linting issues - correct indentation in detectInteractiveSession

1d09c1d

Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

vercel bot deployed to Preview September 30, 2025 09:46 View deployment

Copilot AI requested a review from mrlubos September 30, 2025 09:47

Copilot finished work on behalf of mrlubos September 30, 2025 09:47

Copilot started work on behalf of mrlubos September 30, 2025 10:50 View session

Fix typecheck issues in test files

bfae15d

Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>

vercel bot deployed to Preview September 30, 2025 11:02 View deployment

Copilot finished work on behalf of mrlubos September 30, 2025 11:03

mrlubos approved these changes Sep 30, 2025

View reviewed changes

mrlubos marked this pull request as ready for review September 30, 2025 12:03

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 30, 2025

mrlubos merged commit 1f9056a into main Sep 30, 2025
28 checks passed

mrlubos deleted the copilot/fix-e387455f-4997-4ca9-ae1c-c7691807966c branch September 30, 2025 12:03

dosubot bot added the bug 🔥 Something isn't working label Sep 30, 2025

hey-api bot mentioned this pull request Sep 30, 2025

ci: release #2705

Merged

Uh oh!

Fix GitHub issue report enabled by default - interactive config not being respected #2708

Fix GitHub issue report enabled by default - interactive config not being respected #2708

Uh oh!

Conversation

Copilot AI commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!