这是indexloc提供的服务，不要输入任何密码
Skip to content

🪧 Symbol API partie deux #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2025
Merged

🪧 Symbol API partie deux #2664

merged 2 commits into from
Sep 21, 2025

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Sep 20, 2025 •
edited
Loading

Closes #2632
Closes #2663
Closes #2635
Closes #2560

TODO:

  • add changelogs
  • sorted and grouped import modules
  • output removed from most plugins
  • new hooks.symbols.getFilePath hook
  • update documentation
  • output.fileName (case, name, suffix)
  • hooks.symbols.getFilePath hook
  • ~hooks available in all plugins

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Sep 20, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e1ede9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hey-api/openapi-ts Minor
@hey-api/codegen-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Sep 21, 2025 8:58pm

@mrlubos mrlubos changed the title feat: placement api 🪧 Symbol API partie deux Sep 20, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 20, 2025
View reviewed changes
packages/openapi-ts-tests/main/test/openapi-ts.config.ts

// @ts-ignore
import { customClientPlugin } from '@hey-api/custom-client/plugin';
import { defineConfig } from '@hey-api/openapi-ts';
// @ts-ignore
import { defineConfig, utils } from '@hey-api/openapi-ts';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused import utils.
Copy link
Member Author

@mrlubos mrlubos Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow it

packages/openapi-ts/src/generate/renderer.ts
}
} else if (value.names && value.names.length > 0) {
if (
!isTypeOnly &&

Check warning

Code scanning / CodeQL

Useless conditional Warning

This negation always evaluates to true.
@codecov
Copy link

codecov bot commented Sep 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.16%. Comparing base (e15f535) to head (e1ede9c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2664      +/-   ##
==========================================
+ Coverage   23.83%   24.16%   +0.32%     
==========================================
  Files         379      378       -1     
  Lines       36960    36451     -509     
  Branches     1632     1620      -12     
==========================================
- Hits         8811     8807       -4     
+ Misses      28136    27631     -505     
  Partials       13       13
Flag Coverage Δ
unittests 24.16% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 20, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2664

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2664

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2664

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2664

commit: e1ede9c

@mrlubos mrlubos marked this pull request as ready for review September 21, 2025 20:57
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 21, 2025
@dosubot dosubot bot added docs 📃 Improvements or additions to documentation feature 🚀 New feature or request labels Sep 21, 2025
@mrlubos mrlubos merged commit 1cc31e7 into main Sep 21, 2025
16 of 17 checks passed
@mrlubos mrlubos deleted the feat/registry branch September 21, 2025 21:06
This was referenced Sep 21, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs 📃 Improvements or additions to documentation feature 🚀 New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

2 participants

@mrlubos