这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(parser): add propertiesRequiredByDefault transform option #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2025
Merged

fix(parser): add propertiesRequiredByDefault transform option #2678

merged 3 commits into from
Sep 23, 2025

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Sep 22, 2025 •
edited
Loading

Related #2300

@vercel
Copy link

vercel bot commented Sep 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Sep 23, 2025 0:00am

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Sep 22, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0ed8796

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review September 22, 2025 21:46
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 22, 2025
@dosubot dosubot bot added the feature 🚀 New feature or request label Sep 22, 2025
@codecov
Copy link

codecov bot commented Sep 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 2.36686% with 165 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.20%. Comparing base (6476ecb) to head (0ed8796).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/config/parser.ts 0.00% 94 Missing ⚠️
...i/shared/transforms/propertiesRequiredByDefault.ts 4.22% 68 Missing ⚠️
.../openapi-ts/src/openApi/shared/transforms/index.ts 25.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2678      +/-   ##
==========================================
- Coverage   25.26%   25.20%   -0.06%     
==========================================
  Files         385      386       +1     
  Lines       37086    37186     +100     
  Branches     1781     1781              
==========================================
+ Hits         9369     9373       +4     
- Misses      27704    27800      +96     
  Partials       13       13
Flag Coverage Δ
unittests 25.20% <2.36%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos mrlubos force-pushed the feat/transform-properties-required-by-default branch from 624ce32 to 166c8c5 Compare September 23, 2025 11:47
@mrlubos mrlubos force-pushed the feat/transform-properties-required-by-default branch from 166c8c5 to 0ed8796 Compare September 23, 2025 11:59
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2678

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2678

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2678

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2678

commit: 0ed8796

@mrlubos mrlubos merged commit 23c980c into main Sep 23, 2025
15 of 17 checks passed
@mrlubos mrlubos deleted the feat/transform-properties-required-by-default branch September 23, 2025 12:10
@hey-api hey-api bot mentioned this pull request Sep 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature 🚀 New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrlubos