这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@franworks
Copy link

This PR moves getValidRequestBody to /client-core/bundles/utils, imports and implements this method in the angular, axios, fetch, and next clients

Resolves #2604

Fransis Young added 2 commits September 6, 2025 14:59
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2025

🦋 Changeset detected

Latest commit: aca5a7c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 6, 2025

Someone is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. client Client package related labels Sep 6, 2025
@franworks franworks changed the title Refactor #2604 move get valid request body to core utils Refactor getValidRequestBody to client-core utils Sep 6, 2025
@franworks franworks changed the title Refactor getValidRequestBody to client-core utils refactor(client): moves getValidRequestBody to core-body utils Sep 6, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2605
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2605
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2605
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2605

commit: aca5a7c

@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.14%. Comparing base (67e066f) to head (aca5a7c).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2605      +/-   ##
==========================================
- Coverage   24.19%   24.14%   -0.06%     
==========================================
  Files         363      363              
  Lines       36654    36625      -29     
  Branches     1650     1641       -9     
==========================================
- Hits         8869     8843      -26     
+ Misses      27772    27769       -3     
  Partials       13       13              
Flag Coverage Δ
unittests 24.14% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, looks good!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 7, 2025
@mrlubos mrlubos merged commit 949b2b0 into hey-api:main Sep 7, 2025
11 of 13 checks passed
@hey-api hey-api bot mentioned this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Client package related lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client Improvement: Move getValidRequestBody method from client to core-client utils

2 participants