fix(client-axios): ensures falsy request body can be serialized #2600
Conversation
ensures request is sent with valid serialized or unserialized data resolves: hey-api#2599, related: hey-api#2553
|
|
|
|
Someone is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
@mrlubos, I ran the test:update command to update the snapshots and files that I was not expecting to change were updated. Have you seen this before? |
|
NVM - i needed to update my dependencies |
ae35a98 to
7048a91
Compare
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
==========================================
+ Coverage 24.05% 24.18% +0.12%
==========================================
Files 363 363
Lines 36585 36596 +11
Branches 1628 1644 +16
==========================================
+ Hits 8802 8849 +47
+ Misses 27770 27734 -36
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrlubos
left a comment
There was a problem hiding this comment.
You're getting faster and faster 😀 I wonder if this function should be moved to the shared utils at some point
I was wondering the same thing - thought it might be a good follow up PR. If the shared utils (ie client-core utils) directory is the place, I could move it there. I will create an issue and submit a PR with that improvement. As I was looking through the clients, there are other opportunities to reduce duplication and improve consistency. I will create an issue to start the discussion. |
Resolves: #2599
This PR ensures that when a request defines a falsy
options.body, and anoptions.bodySerializer, the body is serialized, and valid request data is sent in the request.