这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(typescript): handle string and binary string in composite keywords #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

fix(typescript): handle string and binary string in composite keywords #2630

merged 1 commit into from
Sep 10, 2025

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Sep 10, 2025

Fixes #2617

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Sep 10, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025

🦋 Changeset detected

Latest commit: 43a0661

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Sep 10, 2025 3:44pm

@mrlubos mrlubos marked this pull request as ready for review September 10, 2025 15:44
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug 🔥 Something isn't working labels Sep 10, 2025
@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.81%. Comparing base (6e0f060) to head (43a0661).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/tsc/typedef.ts 0.00% 22 Missing ⚠️
...enapi-ts/src/plugins/@hey-api/typescript/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2630      +/-   ##
==========================================
- Coverage   23.82%   23.81%   -0.02%     
==========================================
  Files         379      379              
  Lines       36929    36945      +16     
  Branches     1623     1623              
==========================================
  Hits         8798     8798              
- Misses      28118    28134      +16     
  Partials       13       13
Flag Coverage Δ
unittests 23.81% <4.16%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 10, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2630

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2630

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2630

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2630

commit: 43a0661

@mrlubos mrlubos merged commit 4fb0e1b into main Sep 10, 2025
15 of 17 checks passed
@mrlubos mrlubos deleted the fix/anyof-string-binary branch September 10, 2025 15:52
@hey-api hey-api bot mentioned this pull request Sep 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug 🔥 Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Array<string | Blob | File> type is missing string from union

2 participants

@mrlubos