这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(pinia-colada): optional options in mutation factory #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2025
Merged

fix(pinia-colada): optional options in mutation factory #2593

merged 3 commits into from
Sep 4, 2025

Conversation

@brolnickij
Copy link
Contributor

@brolnickij brolnickij commented Sep 4, 2025

close #2592

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Sep 4, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: 9bcf2a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 4, 2025

@brolnickij is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug 🔥 Something isn't working labels Sep 4, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2593

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2593

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2593

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2593

commit: 9bcf2a8

@codecov
Copy link

codecov bot commented Sep 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.59%. Comparing base (8b8c368) to head (9bcf2a8).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...pi-ts/src/plugins/@pinia/colada/mutationOptions.ts 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2593   +/-   ##
=======================================
  Coverage   23.59%   23.59%           
=======================================
  Files         363      363           
  Lines       36549    36545    -4     
  Branches     1562     1562           
=======================================
  Hits         8622     8622           
+ Misses      27914    27910    -4     
  Partials       13       13
Flag Coverage Δ
unittests 23.59% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mrlubos
mrlubos approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is the same logic used for TanStack Query?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2025
@mrlubos mrlubos merged commit 62cff55 into hey-api:main Sep 4, 2025
12 of 13 checks passed
@hey-api hey-api bot mentioned this pull request Sep 4, 2025
Merged
@brolnickij
Copy link
Contributor Author

brolnickij commented Sep 4, 2025

@mrlubos yep, @tanstack/* plugins has same logic

openapi-ts/packages/openapi-ts/src/plugins/@tanstack/query-core/mutationOptions.ts

Lines 131 to 137 in 8b8c368

parameters: [
{
isRequired: false,
name: 'options',
type: `Partial<${typeData}>`,
},
],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrlubos mrlubos mrlubos approved these changes

Assignees

No one assigned

Labels

bug 🔥 Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@pinia/colada: make options optional for all mutations

2 participants

@brolnickij @mrlubos