这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(client-fetch): serialize body with falsey but valid json values #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(client-fetch): serialize body with falsey but valid json values #2590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca81842
fix(client-fetch): serialize body with falsey but valid json values
LinuCC Sep 4, 2025
e17f7e8
Merge branch 'main' into client-fetch-json-serialize-valid-falsey-values
LinuCC Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions packages/openapi-ts/src/plugins/@hey-api/client-fetch/__tests__/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,4 +220,89 @@ describe('zero-length body handling', () => {
expect(result.data).toBeInstanceOf(Blob);
expect((result.data as Blob).size).toBeGreaterThan(0);
});

it('serializes a json string to a json-parseable body', async () => {
const mockResponse = new Response(null, {
status: 200,
});

const mockFetch: MockFetch = vi.fn().mockResolvedValue(mockResponse);

const result = await client.request({
body: { key: 'value' },
fetch: mockFetch,
method: 'PUT',
url: '/test',
});

expect(await result.request.text()).toBe('{"key":"value"}');
});

it('serializes an empty string to a json-parseable body', async () => {
const mockResponse = new Response(null, {
status: 200,
});

const mockFetch: MockFetch = vi.fn().mockResolvedValue(mockResponse);

const result = await client.request({
body: '',
fetch: mockFetch,
method: 'PUT',
url: '/test',
});

expect(await result.request.text()).toBe('""');
});

it('serializes `0` to a json-parseable body', async () => {
const mockResponse = new Response(null, {
status: 200,
});

const mockFetch: MockFetch = vi.fn().mockResolvedValue(mockResponse);

const result = await client.request({
body: 0,
fetch: mockFetch,
method: 'PUT',
url: '/test',
});

expect(await result.request.text()).toBe('0');
});

it('does not serialize a `null` body', async () => {
const mockResponse = new Response(null, {
status: 200,
});

const mockFetch: MockFetch = vi.fn().mockResolvedValue(mockResponse);

const result = await client.request({
body: null,
fetch: mockFetch,
method: 'PUT',
url: '/test',
});

expect(await result.request.text()).toBe('');
});

it('does not serialize an `undefined` body', async () => {
const mockResponse = new Response(null, {
status: 200,
});

const mockFetch: MockFetch = vi.fn().mockResolvedValue(mockResponse);

const result = await client.request({
body: undefined,
fetch: mockFetch,
method: 'PUT',
url: '/test',
});

expect(await result.request.text()).toBe('');
});
});
2 changes: 1 addition & 1 deletion packages/openapi-ts/src/plugins/@hey-api/client-fetch/bundle/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const createClient = (config: Config = {}): Client => {
await opts.requestValidator(opts);
}

if (opts.body && opts.bodySerializer) {
if (opts.body !== null && opts.body !== undefined && opts.bodySerializer) {
opts.serializedBody = opts.bodySerializer(opts.body);
}

Expand Down
Loading