fix(client): don't rename files that have target suffix #2559
Conversation
|
|
🦋 Changeset detectedLatest commit: eb6ee87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@jgoz is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2559 +/- ##
=======================================
Coverage 23.83% 23.83%
=======================================
Files 361 361
Lines 36080 36080
Branches 1560 1560
=======================================
Hits 8599 8599
Misses 27468 27468
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've seen this bug before but it was combined with something else I was working on, so I didn't realize it's an issue to be fixed |
fixes #2558
This is a comically large PR for what is essentially a one-line fix: don't rename output files if they already contain a
.gensuffix.The reason it's so large is that I added a client generation test case for
clean: falsewhich runs for every client.Although this fixes the bug I reported, I think there is a better solution that I don't have time to contribute. Essentially, each client bundle should have a manifest of what is included and use that to determine which files need to be copied and renamed, rather than using the output directory listing. The manifest would need to be generated at the time of publishing in order to support Yarn's PnP mode; otherwise, the input directory could be used as the manifest.