这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: update schema pruning logic to correctly handle required properties #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2025
Merged

fix: update schema pruning logic to correctly handle required properties #2556

merged 3 commits into from
Aug 29, 2025

Conversation

@carson2222
Copy link
Contributor

@carson2222 carson2222 commented Aug 29, 2025

fix #2543

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Aug 29, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e93eeec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Aug 29, 2025 10:05pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug 🔥 Something isn't working labels Aug 29, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 29, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2556

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2556

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2556

commit: e93eeec

@codecov
Copy link

codecov bot commented Aug 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.81%. Comparing base (61e0956) to head (e93eeec).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...napi-ts/src/openApi/shared/transforms/readWrite.ts 0.00% 26 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2556      +/-   ##
==========================================
- Coverage   23.83%   23.81%   -0.02%     
==========================================
  Files         361      361              
  Lines       36080    36100      +20     
  Branches     1560     1560              
==========================================
  Hits         8599     8599              
- Misses      27468    27488      +20     
  Partials       13       13
Flag Coverage Δ
unittests 23.81% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 29, 2025
@mrlubos mrlubos merged commit 2693f68 into main Aug 29, 2025
12 of 14 checks passed
@mrlubos mrlubos deleted the fix--clean-up-required-array-after-read/write-split branch August 29, 2025 22:13
@github-actions github-actions bot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrlubos mrlubos mrlubos approved these changes

Assignees

No one assigned

Labels

bug 🔥 Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up required array after read/write split

3 participants

@carson2222 @mrlubos