feat: add support for generating const enum as enum type #2541
Conversation
|
|
🦋 Changeset detectedLatest commit: e42d2a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Someone is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2541 +/- ##
==========================================
- Coverage 24.00% 23.81% -0.20%
==========================================
Files 359 361 +2
Lines 35540 36103 +563
Branches 1540 1560 +20
==========================================
+ Hits 8533 8599 +66
- Misses 26994 27491 +497
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrlubos
left a comment
There was a problem hiding this comment.
Once you fix the lint errors, please add a snapshot test and update snapshots with pnpm --filter @test/openapi-ts test:update
| const pluginTypeScript = config.plugins['@hey-api/typescript']; | ||
| onNode( | ||
| tsc.enumDeclaration({ | ||
| asConst: |
There was a problem hiding this comment.
I would've done just asConst: false, but this also works 😬
commit: |
|
@mrlubos Why is my patch coverage 0%? I'd assume that the snapshot tests would cover the new paths, except maybe Functionality itself is working as expected now, so ready to merge if you ask me! |
|
@ixnas reports are broken, it shows project at ~24% as well. Your changes look good, thank you! |
closes #2540